-
Notifications
You must be signed in to change notification settings - Fork 36.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rpcwallet] Don't use floating point #8317
Conversation
Before:
After:
|
Concept ACK. |
yes, it is two different functions to generate the string. Before it used |
I think we should do this (for 0.14) but would require a short part in the release notes. |
utACK. The numbers may be formatted slightly differently, but it's not an API change from the perspective of a client, it still returns a JSON number where a JSON number was returned. No need to mention this in release notes. |
What would I write there? |
Okay for me. |
I think we should be careful to not add too much technical details to the explicit descriptions in the release notes. The release notes are already huge, every major release. Also remember that every commit/PR already gets a mention with the title. |
477777f [rpcwallet] Don't use floating point (MarcoFalke)
Github-Pull: bitcoin#8317 Rebased-From: 477777f
Github-Pull: bitcoin#8317 Rebased-From: 477777f
* Implement BIP 9 GBT changes - BIP9DeploymentInfo struct for static deployment info - VersionBitsDeploymentInfo: Avoid C++11ism by commenting parameter names - getblocktemplate: Make sure to set deployments in the version if it is LOCKED_IN - In this commit, all rules are considered required for clients to support * qa/rpc-tests: bip9-softforks: Add tests for getblocktemplate versionbits updates * getblocktemplate: Explicitly handle the distinction between GBT-affecting softforks vs not * getblocktemplate: Use version/force mutation to support pre-BIP9 clients * Don't use floating point Github-Pull: bitcoin#8317 Rebased-From: 477777f * Send tip change notification from invalidateblock This change is needed to prevent sync_blocks timeouts in the mempool_reorg test after the sync_blocks update in the upcoming commit "[qa] Change sync_blocks to pick smarter maxheight". This change was initially suggested by Suhas Daftuar <[email protected]> in bitcoin#8680 (comment) Github-Pull: bitcoin#9196 Rebased-From: 67c6326 * torcontrol: Explicitly request RSA1024 private key When generating a new service key, explicitly request a RSA1024 one. The bitcoin P2P protocol has no support for the longer hidden service names that will come with ed25519 keys, until it does, we depend on the old hidden service type so make this explicit. See bitcoin#9214. Github-Pull: bitcoin#9234 Rebased-From: 7d3b627 * Bugfix: FRT: don't terminate when keypool is empty Github-Pull: bitcoin#9295 Rebased-From: c24a4f5 * add fundrawtransaction test on a locked wallet with empty keypool Github-Pull: bitcoin#9295 Rebased-From: 1a6eacb
Github-Pull: bitcoin#8317 Rebased-From: 477777f
Bech32 encoding support and t-addr encoding refactor Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#7922 - bitcoin/bitcoin#7825 - bitcoin/bitcoin#8317 - bitcoin/bitcoin#9804 - Only the commit that changed `base58.cpp` - bitcoin/bitcoin#11117 - bitcoin/bitcoin#11259 - bitcoin/bitcoin#11167 - Only the first three commits (the fourth commit depends on #2390, later ones are SegWit-specific). Part of #3058.
Upstream encoding cleanups Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#7922 - bitcoin/bitcoin#7825 - bitcoin/bitcoin#8317 - bitcoin/bitcoin#9804 - Only the commit that changed `base58.cpp` Precursor to #3202.
Upstream encoding cleanups Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#7922 - bitcoin/bitcoin#7825 - bitcoin/bitcoin#8317 - bitcoin/bitcoin#9804 - Only the commit that changed `base58.cpp` Precursor to #3202.
Follow up of 69d605f
fun fact:
The refactor in
getreceivedbyaddress
actually removes the feature to detect ifIsMine()
was false. You can checkgetreceivedbyaddress
== 0 and isfloat(getreceivedbyaddress
)