util: improve bitcoin-wallet exit codes #26067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,7 +36,7 @@ | |||
| for relpath in BINARIES: | |||
| abspath = os.path.join(builddir, relpath) | |||
| try: | |||
| r = subprocess.run([abspath, '--version'], stdout=subprocess.PIPE, universal_newlines=True) | |||
| r = subprocess.run([abspath, "--version"], stdout=subprocess.PIPE, check=True, universal_newlines=True) | |||
There was a problem hiding this comment.
Why change single quote to double quote? Is it a coding style in the Bitcoin Core?
|
As far as I could grasp the codebase, ACK. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
bitcoin-walletso that it doesn't return a non-zero exit code by default, and makes the option handling more inline with the other binaries. i.e outputtingError: too few parametersif you don't pass any options.Fixing this means we can check the process output in
gen-manpages.py; which addresses the remaining review comment from #24263.