script install_db4.sh check for patch command before continuing to install db4
#23579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"./contrib/install_db4.sh: line 71: patch: command not found" is not obscure enough to need an improvement. NAK. |
|
Wouldn't it be best to remove this script? We already have |
|
@katesalazar not looking for an adjustment to the message; only to check dependencies before starting write operations -- at least for new users like myself who may not have everything installed yet. |
|
For reference, I was following this doc: https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#berkeley-db |
|
Concept ACK, thanks for your contribution.
The depends framework doesn't work on all the platforms that this script works, IIRC. Think of the BSDs. |
|
Code review and tested ACK 7bb8eb0 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 26, 2021
…before continuing to install db4 7bb8eb0 script install_db4.sh added check for patch command (Nathan Garabedian) Pull request description: First contribution. I've read the CONTRIBUTING guide and hope I'm doing this correctly, but please kindly point out anything I should do differently. I found while running the contrib/install_db4.sh patch that it would fail suddenly with "patch: command not found". I'd rather see it fail early before doing any work, allow me to install the `patch` command, and then run again. (CentOS Linux) Here's a PR proposed to fix it. error message: ``` ... db-4.8.30.NC/txn/txn_rec.c db-4.8.30.NC/txn/txn_region.c db-4.8.30.NC/txn/txn_stat.c db-4.8.30.NC/txn/txn_util.c ./contrib/install_db4.sh: line 71: patch: command not found ``` ACKs for top commit: laanwj: Code review and tested ACK 7bb8eb0 Tree-SHA512: f0c59ec509dff6637c41eec2923fe708456c3a7ae04495b12c5492681a1f95d1d9a643a2649df13ba8e6ac708680c627657b6989b62eff63be021e92e1d7c4a8
This was referenced Dec 2, 2021
laanwj
added a commit
to bitcoin-core/gui
that referenced
this pull request
Dec 9, 2021
…nstall_db4.sh b062da0 contrib: add check for wget command in install_db4.sh (Florian Baumgartl) Pull request description: This PR is motivated by bitcoin/bitcoin@7bb8eb0 commit (see also bitcoin/bitcoin#23579) and ensures that `install_db4.sh` will check for `curl` and `wget` utilities. Currently, the conditional statement in the `http_get()` function assumes that `wget` is always available but we actually do not know it since there is no check or validation for the `wget` command. So let's make sure that we check for both commands and print an error message if they are missing. ACKs for top commit: jamesob: ACK bitcoin/bitcoin@b062da0 laanwj: Tested ACK b062da0 shaavan: ACK b062da0 Tree-SHA512: bfc1ccad9a5b99764b759e02dde1976616c2af4747b7d5af8e71d33624c2cb21d93a09a60d244756e86bbd5fd7541331c62d7eb84d3458b6a059f1d9cb2a5f42
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 10, 2021
…b4.sh b062da0 contrib: add check for wget command in install_db4.sh (Florian Baumgartl) Pull request description: This PR is motivated by bitcoin@7bb8eb0 commit (see also bitcoin#23579) and ensures that `install_db4.sh` will check for `curl` and `wget` utilities. Currently, the conditional statement in the `http_get()` function assumes that `wget` is always available but we actually do not know it since there is no check or validation for the `wget` command. So let's make sure that we check for both commands and print an error message if they are missing. ACKs for top commit: jamesob: ACK bitcoin@b062da0 laanwj: Tested ACK b062da0 shaavan: ACK b062da0 Tree-SHA512: bfc1ccad9a5b99764b759e02dde1976616c2af4747b7d5af8e71d33624c2cb21d93a09a60d244756e86bbd5fd7541331c62d7eb84d3458b6a059f1d9cb2a5f42
RandyMcMillan
pushed a commit
to RandyMcMillan/mempool-tab
that referenced
this pull request
Dec 23, 2021
…nstall_db4.sh 332d756 contrib: add check for wget command in install_db4.sh (Florian Baumgartl) Pull request description: This PR is motivated by bitcoin/bitcoin@917d12d commit (see also bitcoin/bitcoin#23579) and ensures that `install_db4.sh` will check for `curl` and `wget` utilities. Currently, the conditional statement in the `http_get()` function assumes that `wget` is always available but we actually do not know it since there is no check or validation for the `wget` command. So let's make sure that we check for both commands and print an error message if they are missing. ACKs for top commit: jamesob: ACK bitcoin/bitcoin@332d756 laanwj: Tested ACK 332d756 shaavan: ACK 332d756 Tree-SHA512: bfc1ccad9a5b99764b759e02dde1976616c2af4747b7d5af8e71d33624c2cb21d93a09a60d244756e86bbd5fd7541331c62d7eb84d3458b6a059f1d9cb2a5f42
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First contribution. I've read the CONTRIBUTING guide and hope I'm doing this correctly, but please kindly point out anything I should do differently.
I found while running the contrib/install_db4.sh patch that it would fail suddenly with "patch: command not found". I'd rather see it fail early before doing any work, allow me to install the
patchcommand, and then run again. (CentOS Linux) Here's a PR proposed to fix it.error message: