test: Avoid connecting to real network when running tests #21254
Conversation
Every (sub)test in the framework assumes the node is running, except for the (sub)tests in this file. Remove that confusion by stopping the node at the start of every subtest, instead of at the end.
Can be reviewed with --word-diff-regex=.
maflcko
force-pushed
the
2102-testNoTelemetry
branch
from
fa2240e to
fa730e9
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
ACK fa730e9 Can you add a note which test was connecting to the outside world? I assume it's one of the few tests that uses mainnet? |
|
I haven't checked if any of the current tests reach out right now, but any non-regtest test might be affected. |
|
Concept ACK Good catch! Accidental telemetry is still telemetry and should be removed. |
…ing tests fa730e9 test: Avoid connecting to real network when running tests (MarcoFalke) fa1b713 test: Assume node is running in subtests (MarcoFalke) Pull request description: Introduced in bitcoin#19884 ACKs for top commit: Sjors: ACK fa730e9 Tree-SHA512: fe132a9ffe2fae1ab16857a3dec9839526fdf74d27a1ae794fbffca8356f639c4b916dc888b260281e9cc793916706c18d1687ebb5a076d4e1c481d218d308d3
|
To detect accidental introduction of telemetry in the future: could we perhaps guard against external connections in tests via say a seccomp restricted job in Travis? Perhaps |
|
Sure, pull request welcome |
Can be reviewed with --word-diff-regex=. Github-Pull: bitcoin#21254 Rebased-From: fa730e9
Summary: Backport of [[bitcoin/bitcoin#21254 | core#21254]]. This is the complete fix for the p2p_dos_header_tree.py test, so the temporary fix introduced in D10908 can be reverted. Depends on D10909. Test Plan: ninja all check-functional Reviewers: #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Differential Revision: https://reviews.bitcoinabc.org/D10911
Introduced in #19884