Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Make valgrind.supp work on aarch64 #19159

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Jun 3, 2020

Was easy to fix by simply removing a line

The equivalent suppression on aarch64 looks like:

{
   <insert_a_suppression_name_here>
   Memcheck:Param
   pwrite64(buf)
   fun:__libc_pwrite64
   fun:pwrite
   fun:__os_io
   obj:/usr/lib/aarch64-linux-gnu/libdb_cxx-5.3.so
   fun:__log_flush_int
   fun:__log_flush
   fun:__memp_sync_int
   fun:__db_sync
   fun:__db_refresh
   fun:__db_close
   fun:__fop_subdb_setup
   fun:__db_open
   fun:__db_open_pp
}
@maflcko maflcko added the Tests label Jun 3, 2020
@maflcko
Copy link
Member Author

maflcko commented Jun 3, 2020

If someone wants to try this at home, I had to crank up the timeout factor:

./test/functional/test_runner.py --valgrind -j 1 --timeout-factor=10

@practicalswift
Copy link
Contributor

ACK fab7d95 -- diff looks correct

@fanquake fanquake merged commit 76e6452 into bitcoin:master Jun 4, 2020
@maflcko maflcko deleted the 2006-valgrindAarch64 branch June 4, 2020 14:02
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jun 4, 2020
fab7d95 test: Make valgrind.supp work on aarch64 (MarcoFalke)

Pull request description:

  Was easy to fix by simply removing a line

ACKs for top commit:
  practicalswift:
    ACK fab7d95 -- diff looks correct

Tree-SHA512: d2d7c6cac453a3177c20e256ec50a03066f8dbf5ae45299077ccf4a2b45a3a40252b1b5fcaf9224a59bb5c3df5bd90ac58af27eb0f47dc87c2640df5b2b460ca
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants