Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Disable s390 build on travis #18106

Merged
merged 1 commit into from
Feb 10, 2020
Merged

test: Disable s390 build on travis #18106

merged 1 commit into from
Feb 10, 2020

Conversation

laanwj
Copy link
Member

@laanwj laanwj commented Feb 10, 2020

Travis is consistently failing on s390 due to out of disk space issues,
which causes false positives. Disable the s390 build for now until
this is fixed some other way.

@laanwj
test: Disable s390 build on travis
b0a0129 
Travis is consistently failing on s390 due to out of disk space issues,
which causes false positives. Disable the s390 build for now until
this is fixed some other way.
@laanwj laanwj added the Tests label Feb 10, 2020
jonasschnelli
jonasschnelli approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@jonasschnelli jonasschnelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b0a0129

@maflcko
Copy link
Member

maflcko commented Feb 10, 2020

ACK b0a0129 🍠

Show signature and timestamp

Signature:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK b0a01299ed8cc2026e91a8dcad880b700e462cee 🍠
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUgnPgv+J6d1S2pkBh7zvloURbOWop0LoUHdHQhcMCjqkMF4ip8uwNcxHYMJc8Z1
cGEPbJNaIV3u6I27qUyWD9SRq40bJ/SHcQMf5EHwno+qQQkKXvuh9iXU9F2uhNi5
TFVLoYYuPtjj9n43s2uVZ6j65tWaxiM8g1DfZ0REMAQProeBJo7udF0gX/7CerJ1
FtbsEVXbNsuGviop+cbMzfljXUJ815WDHOoBFJU3Y7N9YQBKdRCX5ftiTH2N8Dk3
QNSM6DWVzucw9xvPLT7TI4tmXLdjxeAwAS/j3EIVfRqwNyQMLuD0sPyqEL13CGkH
dRgLvnpsDnHcs3lvksOMvdOZUVfw40PmWWe43H25TQuINluloUyvaPh0uTwTVj6H
SNdMFNLDpfyRp1xLYpR9OF/Q0PHooLmIYULYLMNUOpV2zquElNilPkRlZ29CvEcw
O6HPupSqiakiA4FqhlM01MP8nWf8OMBFRU+KAi9Vj0TRdNNsrNQEBXEC8mG0OjWj
lmNKoIux
=DyHG
-----END PGP SIGNATURE-----

Timestamp of file with hash be9b063da737a9a2d9f858677abab1e640933551d246b4c68bfb22fa759e5d46 -

maflcko pushed a commit that referenced this pull request Feb 10, 2020
Merge #18106: test: Disable s390 build on travis
ab7915f 
b0a0129 test: Disable s390 build on travis (Wladimir J. van der Laan)

Pull request description:

  Travis is consistently failing on s390 due to out of disk space issues,
  which causes false positives. Disable the s390 build for now until
  this is fixed some other way.

ACKs for top commit:
  MarcoFalke:
    ACK b0a0129 🍠
  jonasschnelli:
    ACK b0a0129

Tree-SHA512: ae8a78fa03bc620d802e4992d46929a0a4b801b50a6066d8f093f93fc5ebbc010d221c04787cbfc75436a2c40f9292257bf85fbb251593e21afff11756b6d8d4
@maflcko maflcko merged commit b0a0129 into bitcoin:master Feb 10, 2020
@maflcko maflcko mentioned this pull request Feb 10, 2020
Closed
@elichai
Copy link
Contributor

elichai commented Feb 10, 2020

I would prefer to add it to allow_failures that way it won't fail the CI because of it but you can still manually check the results to make sure it's fine on BE, or ignore it if it's because of disk space (and then in PRs that are relevant to endianess(like serialization PRs) we could make sure s390x passes)

@laanwj
Copy link
Member Author

laanwj commented Feb 10, 2020

I would prefer this to be fixed; the test VMs have a partition with enough space and it could be worked around with some docker magic, apparently. See #18016. I don't know anything about docker though.

After that, this can be re-enabled.

@MarkLTZ MarkLTZ mentioned this pull request Apr 4, 2020
Closed
@hebasto hebasto mentioned this pull request Apr 8, 2020
Merged
maflcko pushed a commit that referenced this pull request Apr 9, 2020
Merge #18569: ci: Add big endian native s390x build
1ae366e 
6136a96 ci: Rename RUN_CI_ON_HOST to DANGER_RUN_CI_ON_HOST (Hennadii Stepanov)
97ba77a ci: Add native s390x (Hennadii Stepanov)

Pull request description:

  Unlike the Docker wrapped solution (#17591) this PR suggests running on host system directly.

  This approach makes builds quick and stable (see: #18106).

  The excerpt from the Travis log:
  ```
  ...
  Running on host system without docker wrapper
  ...
  Byte Order: Big Endian
  ...
  ```

ACKs for top commit:
  MarcoFalke:
    ACK 6136a96

Tree-SHA512: 1b591de13e38d10a35217e1de11cbd648a359d18d16eed166fac18ea5788b58cc9fc6d407086ed342b99e57e479efd951a0ea693710177e500eb116316b9a788
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonasschnelli jonasschnelli jonasschnelli approved these changes

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laanwj @maflcko @elichai @jonasschnelli