Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Mention PR Club in CONTRIBUTING.md #17772

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

cvengler
Copy link
Contributor

As we have a "Review Club" label it would be worth mentioning it in the CONTRIBUTING.md file for beginners.

@fanquake fanquake added the Docs label Dec 18, 2019
Copy link

@michaelfolkson michaelfolkson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@laanwj
Copy link
Member

laanwj commented Dec 19, 2019

ACK

@practicalswift
Copy link
Contributor

practicalswift commented Dec 19, 2019

ACK 34d826e -- The Bitcoin Core PR Review Club is a great effort to introduce new contributors to the project in a positive and friendly way! We need that kind of newcomer friendly on-ramps to attract and educate the next generation of contributors! Kudos to @jnewbery for helping secure the project also in the super long-term :)

maflcko pushed a commit that referenced this pull request Dec 19, 2019
34d826e doc: Mention PR Club in CONTRIBUTING.md (Emil Engler)

Pull request description:

  As we have a ["Review Club"](https://github.com/bitcoin/bitcoin/labels/Review%20club) label it would be worth mentioning it in the CONTRIBUTING.md file for beginners.

ACKs for top commit:
  practicalswift:
    ACK 34d826e -- The Bitcoin Core PR Review Club is a great effort to introduce new contributors to the project in a positive and friendly way! We need that kind of newcomer friendly on-ramps to attract and educate the next generation of contributors! Kudos to @ jnewbery for helping secure the project also in the super long-term :)

Tree-SHA512: 9c6cbe9a82e1f13db10ad19c50a55566dbe3f5ccaf5b91f75c5a743f7f4f690515274d64c132460791bd4d8e76255b5cbfb2877908459734b52e3fbdba71fbb3
@maflcko maflcko merged commit 34d826e into bitcoin:master Dec 19, 2019
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants