Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appveyor install libevent[thread] vcpkg #17592

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

sipsorcery
Copy link
Contributor

As per #17586 the default libevent vcpkg install now has thread disabled. This PR installs libevent with the thread feature enabled.

@laanwj
Copy link
Member

laanwj commented Nov 25, 2019

ACK (assuming this passes AppVeyor)

Please shorten the commit message though—"As per #17586 the default libevent vcpkg install now has thread disabled. This PR installs libevent with the thread feature enabled." would be better as a commit body than title.

As per bitcoin#17586 the default libevent vcpkg install now has thread disabled. This PR installs libevent with the thread feature enabled.
@sipsorcery sipsorcery force-pushed the vcpkg_libevent_thread branch from 2238bce to f13e274 Compare November 25, 2019 13:36
maflcko pushed a commit that referenced this pull request Nov 25, 2019
f13e274 Appveyor install libevent[thread] vcpkg (Aaron Clauson)

Pull request description:

  As per #17586 the default libevent vcpkg install now has thread disabled. This PR installs libevent with the thread feature enabled.

Top commit has no ACKs.

Tree-SHA512: 5448113f0444170777400fef3582719845ca50d61d9382dfaacc55c43d477dd714456e38a3094e9b6858d93e84def11c2efa46902b52648c9f0c9362cc909147
@maflcko maflcko merged commit f13e274 into bitcoin:master Nov 25, 2019
@sipsorcery sipsorcery deleted the vcpkg_libevent_thread branch November 25, 2019 15:23
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants