Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add historical 0.19.0 release notes #17422

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Nov 8, 2019

No description provided.

@fanquake fanquake added the Docs label Nov 8, 2019
@laanwj
Copy link
Member

laanwj commented Nov 8, 2019

ACK fec230e
looks like there is a small difference with https://github.com/bitcoin/bitcoin/blob/v0.19.0/doc/release-notes.md

$ diff -du ../bitcoin-0.19/doc/release-notes.md doc/release-notes/release-notes-0.19.0.md
--- ../bitcoin-0.19/doc/release-notes.md        2019-11-08 21:11:14.775014215 +0100
+++ doc/release-notes/release-notes-0.19.0.md   2019-11-08 23:15:15.866763153 +0100
@@ -1,6 +1,3 @@
-0.19.0 Release Notes
-====================
-
 Bitcoin Core version 0.19.0 is now available from:
 
   <https://bitcoincore.org/bin/bitcoin-core-0.19.0/>

Then again, the "0.19.0 Release Notes" at the beginning is inconsistent with any other release notes in the archive so that's fine with me.

laanwj added a commit that referenced this pull request Nov 8, 2019
fec230e doc: add historical 0.19.0 release notes (fanquake)

Pull request description:

ACKs for top commit:
  laanwj:
    ACK fec230e

Tree-SHA512: c0c83cd357e58acb7969b02a607fb6b40536f1c1072c25f58b0c6b6b9f50372f33403db51e846456b0f3f1cb3782a0b5c60604cb81e11a2cb99af664249c9069
@laanwj laanwj merged commit fec230e into bitcoin:master Nov 8, 2019
@fanquake
Copy link
Member Author

fanquake commented Nov 8, 2019

looks like there is a small difference with

Yep, I'd removed that as it wasn't present in any of the other historical notes.

@fanquake fanquake deleted the add_019_relnotes branch November 8, 2019 22:31
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Oct 20, 2020
Summary:
67d99900b0d770038c9c5708553143137b124a6c make SaltedOutpointHasher noexcept (Martin Ankerl)

Pull request description:

  If the hash is not `noexcept`, `unorderd_map` has to assume that it can throw an exception. Thus when rehashing care needs to be taken. libstdc++ solves this by simply caching the hash value, which increases memory of each node by 8 bytes. Adding `noexcept` prevents this caching. In my experiments with `-reindex-chainstate -stopatheight=594000`, memory usage (maximum resident set size) has decreased by 9.4% while runtime has increased by 1.6% due to additional hashing. Additionally, memusage::DynamicUsage() is now more accurate and does not underestimate.

  |                                       | runtime h:mm:ss | max RSS kbyte |
  |---------------------------------------|-----------------|--------------|
  | master                                |         4:13:59 |      7696728 |
  | 2019-09-SaltedOutpointHasher-noexcept |         4:18:11 |      6971412 |
  | change                                |          +1.65% |       -9,42% |

  Comparison of progress masters vs. 2019-09-SaltedOutpointHasher-noexcept
  ![out](https://user-images.githubusercontent.com/14386/65541887-69424e00-df0e-11e9-8644-b3a068ed8c3f.png)

Backport of Core [[bitcoin/bitcoin#16957 | PR16957]]

Release notes were backported from Core [[bitcoin/bitcoin#17422 | PR17422]]

Test Plan: `ninja check check-functional` for sanity

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7996
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 27, 2021
fec230e doc: add historical 0.19.0 release notes (fanquake)

Pull request description:

ACKs for top commit:
  laanwj:
    ACK fec230e

Tree-SHA512: c0c83cd357e58acb7969b02a607fb6b40536f1c1072c25f58b0c6b6b9f50372f33403db51e846456b0f3f1cb3782a0b5c60604cb81e11a2cb99af664249c9069
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
fec230e doc: add historical 0.19.0 release notes (fanquake)

Pull request description:

ACKs for top commit:
  laanwj:
    ACK fec230e

Tree-SHA512: c0c83cd357e58acb7969b02a607fb6b40536f1c1072c25f58b0c6b6b9f50372f33403db51e846456b0f3f1cb3782a0b5c60604cb81e11a2cb99af664249c9069
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
fec230e doc: add historical 0.19.0 release notes (fanquake)

Pull request description:

ACKs for top commit:
  laanwj:
    ACK fec230e

Tree-SHA512: c0c83cd357e58acb7969b02a607fb6b40536f1c1072c25f58b0c6b6b9f50372f33403db51e846456b0f3f1cb3782a0b5c60604cb81e11a2cb99af664249c9069
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants