rpc: add missing fields to wallet rpc help output #16689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanquake
changed the title
|
Concept ACK |
luke-jr
suggested changes
Aug 23, 2019
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Aug 23, 2019
Fields involvesWatchonly, generated, walletconflicts were missing in result description of listtransactions, listsinceblock, gettransactions Github-Pull: bitcoin#16689 Rebased-From: b8ea120
ariard
force-pushed
the
2019-08-missing-fields-rpcs-help
branch
from
b8ea120 to
fbc3c9f
Compare
|
Updated at fbc3c9f as suggested in #16689 (comment) (but only output from WalletTxToJSON as we may have small diffs between RPCs for other fields) |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
ariard
force-pushed
the
2019-08-missing-fields-rpcs-help
branch
from
fbc3c9f to
c86def6
Compare
promag
reviewed
Aug 26, 2019
src/wallet/rpcwallet.cpp
Outdated
| " transaction conflicts with the block chain.\n" | ||
| " \"generated\": xxx, (bool) Only returns true if transaction only input is a coinbase one, otherwise false.\n" | ||
| " \"trusted\": xxx, (bool) Whether we consider the outputs of this unconfirmed transaction safe to spend.\n" | ||
| " \"blockhash\": \"hashvalue\", (string) The block hash containing the transaction.\n" |
There was a problem hiding this comment.
nit, try to have it aligned with surrounding lines.
There was a problem hiding this comment.
You mean blockhash compare to trusted and others ? Don't get the misalignment here
There was a problem hiding this comment.
I think the first commit (moveonly) should actually be moveonly (via git diff --color-moved=dimmed-zebra).
Otherwise the rendered whitespace will be messed up. (You can get the help text with the help listtransactions rpc)
ariard
force-pushed
the
2019-08-missing-fields-rpcs-help
branch
from
c86def6 to
626dc9c
Compare
kristapsk
suggested changes
Sep 18, 2019
src/wallet/rpcwallet.cpp
Outdated
| " \"blockindex\": n, (numeric) The index of the transaction in the block that includes it.\n" | ||
| " \"blocktime\": xxx, (numeric) The block time in seconds since epoch (1 Jan 1970 GMT).\n" | ||
| " \"txid\": \"transactionid\", (string) The transaction id.\n" | ||
| " \"walletconflicts: \"hashvalue\", (array) List of txids that conflict with this transaction.\n" |
There was a problem hiding this comment.
It returns array here. So \"walletconflicts\": [ \"TXID\", ... ] should be used instead. See #16869 as an example.
ariard
force-pushed
the
2019-08-missing-fields-rpcs-help
branch
from
626dc9c to
a0b9216
Compare
Rendered diff:diff --git a/gettransaction b/gettransaction
index cf09efd..7ef6106 100644
--- a/gettransaction
+++ b/gettransaction
@@ -10,37 +10,46 @@ Arguments:
Result:
{
"amount" : x.xxx, (numeric) The transaction amount in BTC
"fee": x.xxx, (numeric) The amount of the fee in BTC. This is negative and only available for the
'send' category of transactions.
- "confirmations" : n, (numeric) The number of confirmations
- "blockhash" : "hash", (string) The block hash
- "blockindex" : xx, (numeric) The index of the transaction in the block that includes it
- "blocktime" : ttt, (numeric) The time in seconds since epoch (1 Jan 1970 GMT)
+ "confirmations": n, (numeric) The number of confirmations for the transaction. Negative confirmations indicate the
+ transaction conflicts with the block chain.
+ "generated": xxx, (bool) Only returns true if transaction only input is a coinbase one, otherwise false.
+ "trusted": xxx, (bool) Whether we consider the outputs of this unconfirmed transaction safe to spend.
+ "blockhash": "hashvalue", (string) The block hash containing the transaction.
+ "blockindex": n, (numeric) The index of the transaction in the block that includes it.
+ "blocktime": xxx, (numeric) The block time in seconds since epoch (1 Jan 1970 GMT).
"txid": "transactionid", (string) The transaction id.
- "time" : ttt, (numeric) The transaction time in seconds since epoch (1 Jan 1970 GMT)
- "timereceived" : ttt, (numeric) The time received in seconds since epoch (1 Jan 1970 GMT)
+ "walletconflicts": [ (array) List of txids.
+ "txid", (string) The conflicting txid.
+ ...
+ ],
+ "time": xxx, (numeric) The transaction time in seconds since epoch (midnight Jan 1 1970 GMT).
+ "timereceived": xxx, (numeric) The time received in seconds since epoch (midnight Jan 1 1970 GMT).
+ "comment": "...", (string) If a comment is associated with the transaction, only present if not empty.
"bip125-replaceable": "yes|no|unknown", (string) Whether this transaction could be replaced due to BIP125 (replace-by-fee);
may be unknown for unconfirmed transactions not in the mempool
"details" : [
{
+ "involvesWatchonly": xxx, (bool) Only returns true if imported addresses were involved in transaction.
"address" : "address", (string) The bitcoin address involved in the transaction
"category" : (string) The transaction category.
"send" Transactions sent.
"receive" Non-coinbase transactions received.
"generate" Coinbase transactions received with more than 100 confirmations.
"immature" Coinbase transactions received with 100 or fewer confirmations.
"orphan" Orphaned coinbase transactions received.
"amount" : x.xxx, (numeric) The amount in BTC
"label" : "label", (string) A comment for the address/transaction, if any
"vout" : n, (numeric) the vout value
"fee": x.xxx, (numeric) The amount of the fee in BTC. This is negative and only available for the
'send' category of transactions.
"abandoned": xxx (bool) 'true' if the transaction has been abandoned (inputs are respendable). Only available for the
'send' category of transactions.
}
,...
],
"hex" : "data" (string) Raw data for transaction
"decoded" : transaction (json object) Optional, the decoded transaction (only present when `verbose` is passed), equivalent to the
RPC decoderawtransaction method, or the RPC getrawtransaction method when `verbose` is passed.
}
diff --git a/listreceivedbyaddress b/listreceivedbyaddress
index 3e895f4..566ddb3 100644
--- a/listreceivedbyaddress
+++ b/listreceivedbyaddress
@@ -11,15 +11,15 @@ Arguments:
Result:
[
{
- "involvesWatchonly" : true, (bool) Only returned if imported addresses were involved in transaction
+ "involvesWatchonly" : true, (bool) Only returns true if imported addresses were involved in transaction.
"address" : "receivingaddress", (string) The receiving address
"amount" : x.xxx, (numeric) The total amount in BTC received by the address
"confirmations" : n, (numeric) The number of confirmations of the most recent transaction included
"label" : "label", (string) The label of the receiving address. The default label is "".
"txids": [
"txid", (string) The ids of transactions received with the address
...
]
}
,...
]
diff --git a/listreceivedbylabel b/listreceivedbylabel
index 38d25bf..d716f9b 100644
--- a/listreceivedbylabel
+++ b/listreceivedbylabel
@@ -10,10 +10,10 @@ Arguments:
Result:
[
{
- "involvesWatchonly" : true, (bool) Only returned if imported addresses were involved in transaction
+ "involvesWatchonly" : true, (bool) Only returns true if imported addresses were involved in transaction.
"amount" : x.xxx, (numeric) The total amount received by addresses with this label
"confirmations" : n, (numeric) The number of confirmations of the most recent transaction included
"label" : "label" (string) The label of the receiving address. The default label is "".
}
,...
]
diff --git a/listsinceblock b/listsinceblock
index be347aa..9a9b8f7 100644
--- a/listsinceblock
+++ b/listsinceblock
@@ -14,35 +14,43 @@ Arguments:
Result:
{
"transactions": [
+ "involvesWatchonly": xxx, (bool) Only returns true if imported addresses were involved in transaction.
"address":"address", (string) The bitcoin address of the transaction.
"category": (string) The transaction category.
"send" Transactions sent.
"receive" Non-coinbase transactions received.
"generate" Coinbase transactions received with more than 100 confirmations.
"immature" Coinbase transactions received with 100 or fewer confirmations.
"orphan" Orphaned coinbase transactions received.
"amount": x.xxx, (numeric) The amount in BTC. This is negative for the 'send' category, and is positive
for all other categories
"vout" : n, (numeric) the vout value
"fee": x.xxx, (numeric) The amount of the fee in BTC. This is negative and only available for the 'send' category of transactions.
- "confirmations": n, (numeric) The number of confirmations for the transaction.
- When it's < 0, it means the transaction conflicted that many blocks ago.
+ "confirmations": n, (numeric) The number of confirmations for the transaction. Negative confirmations indicate the
+ transaction conflicts with the block chain.
+ "generated": xxx, (bool) Only returns true if transaction only input is a coinbase one, otherwise false.
+ "trusted": xxx, (bool) Whether we consider the outputs of this unconfirmed transaction safe to spend.
"blockhash": "hashvalue", (string) The block hash containing the transaction.
"blockindex": n, (numeric) The index of the transaction in the block that includes it.
"blocktime": xxx, (numeric) The block time in seconds since epoch (1 Jan 1970 GMT).
"txid": "transactionid", (string) The transaction id.
- "time": xxx, (numeric) The transaction time in seconds since epoch (Jan 1 1970 GMT).
- "timereceived": xxx, (numeric) The time received in seconds since epoch (Jan 1 1970 GMT).
+ "walletconflicts": [ (array) List of txids.
+ "txid", (string) The conflicting txid.
+ ...
+ ],
+ "time": xxx, (numeric) The transaction time in seconds since epoch (midnight Jan 1 1970 GMT).
+ "timereceived": xxx, (numeric) The time received in seconds since epoch (midnight Jan 1 1970 GMT).
+ "comment": "...", (string) If a comment is associated with the transaction, only present if not empty.
"bip125-replaceable": "yes|no|unknown", (string) Whether this transaction could be replaced due to BIP125 (replace-by-fee);
may be unknown for unconfirmed transactions not in the mempool
"abandoned": xxx, (bool) 'true' if the transaction has been abandoned (inputs are respendable). Only available for the 'send' category of transactions.
"comment": "...", (string) If a comment is associated with the transaction.
"label" : "label" (string) A comment for the address/transaction, if any
"to": "...", (string) If a comment to is associated with the transaction.
],
"removed": [
<structure is the same as "transactions" above, only present if include_removed=true>
Note: transactions that were re-added in the active chain will appear as-is in this array, and may thus have a positive confirmation count.
],
"lastblock": "lastblockhash" (string) The hash of the block (target_confirmations-1) from the best block on the main chain. This is typically used to feed back into listsinceblock the next time you call it. So you would generally use a target_confirmations of say 6, so you will be continually re-notified of transactions until they've reached 6 confirmations plus any new ones
}
diff --git a/listtransactions b/listtransactions
index 438677e..ef584d4 100644
--- a/listtransactions
+++ b/listtransactions
@@ -14,32 +14,38 @@ Arguments:
Result:
[
{
+ "involvesWatchonly": xxx, (bool) Only returns true if imported addresses were involved in transaction.
"address":"address", (string) The bitcoin address of the transaction.
"category": (string) The transaction category.
"send" Transactions sent.
"receive" Non-coinbase transactions received.
"generate" Coinbase transactions received with more than 100 confirmations.
"immature" Coinbase transactions received with 100 or fewer confirmations.
"orphan" Orphaned coinbase transactions received.
"amount": x.xxx, (numeric) The amount in BTC. This is negative for the 'send' category, and is positive
for all other categories
"label": "label", (string) A comment for the address/transaction, if any
"vout": n, (numeric) the vout value
"fee": x.xxx, (numeric) The amount of the fee in BTC. This is negative and only available for the
'send' category of transactions.
"confirmations": n, (numeric) The number of confirmations for the transaction. Negative confirmations indicate the
- transaction conflicts with the block chain
+ transaction conflicts with the block chain.
+ "generated": xxx, (bool) Only returns true if transaction only input is a coinbase one, otherwise false.
"trusted": xxx, (bool) Whether we consider the outputs of this unconfirmed transaction safe to spend.
"blockhash": "hashvalue", (string) The block hash containing the transaction.
"blockindex": n, (numeric) The index of the transaction in the block that includes it.
"blocktime": xxx, (numeric) The block time in seconds since epoch (1 Jan 1970 GMT).
"txid": "transactionid", (string) The transaction id.
+ "walletconflicts": [ (array) List of txids.
+ "txid", (string) The conflicting txid.
+ ...
+ ],
"time": xxx, (numeric) The transaction time in seconds since epoch (midnight Jan 1 1970 GMT).
"timereceived": xxx, (numeric) The time received in seconds since epoch (midnight Jan 1 1970 GMT).
- "comment": "...", (string) If a comment is associated with the transaction.
+ "comment": "...", (string) If a comment is associated with the transaction, only present if not empty.
"bip125-replaceable": "yes|no|unknown", (string) Whether this transaction could be replaced due to BIP125 (replace-by-fee);
may be unknown for unconfirmed transactions not in the mempool
"abandoned": xxx (bool) 'true' if the transaction has been abandoned (inputs are respendable). Only available for the
'send' category of transactions.
}
]
|
maflcko
reviewed
Sep 22, 2019
kristapsk
suggested changes
Sep 23, 2019
fanquake
reviewed
Sep 24, 2019
src/wallet/rpcwallet.cpp
Outdated
| return " \"confirmations\": n, (numeric) The number of confirmations for the transaction. Negative confirmations indicate the\n" | ||
| " transaction conflicts with the block chain.\n" | ||
| " \"generated\": xxx, (bool) Only returns true if transaction only input is a coinbase one, otherwise false.\n" | ||
| " \"trusted\": xxx, (bool) Whether we consider the outputs of this unconfirmed transaction safe to spend.\n" |
There was a problem hiding this comment.
Could you update this to be (bool, optional) and address this comment:
if this is optional, I think the help text should also mention when the value is present or not.
There was a problem hiding this comment.
Rewrote comment but not sure about optional, it seems to be reserved when a optional feature is involved like HD-wallet, which is not the case with IsTrusted
|
@ariard If you'd like this to be included in 0.19, please make the suggested changes today or tomorrow, otherwise it will miss the split-off. |
ariard
force-pushed
the
2019-08-missing-fields-rpcs-help
branch
from
a0b9216 to
b8d3d27
Compare
|
Sorry for the delay, was offline for few days, updated with suggested changes at 396da1d |
ariard
force-pushed
the
2019-08-missing-fields-rpcs-help
branch
from
b8d3d27 to
396da1d
Compare
|
Rendered diff: diff --git a/gettransaction b/gettransaction
index cf09efd..84731c7 100644
--- a/gettransaction
+++ b/gettransaction
@@ -10,39 +10,47 @@ Arguments:
Result:
{
"amount" : x.xxx, (numeric) The transaction amount in BTC
"fee": x.xxx, (numeric) The amount of the fee in BTC. This is negative and only available for the
'send' category of transactions.
- "confirmations" : n, (numeric) The number of confirmations
- "blockhash" : "hash", (string) The block hash
- "blockindex" : xx, (numeric) The index of the transaction in the block that includes it
- "blocktime" : ttt, (numeric) The time in seconds since epoch (1 Jan 1970 GMT)
+ "confirmations": n, (numeric) The number of confirmations for the transaction. Negative confirmations indicate the
+ transaction conflicts with the block chain.
+ "generated": xxx, (bool) Only present if transaction only input is a coinbase one.
+ "trusted": xxx, (bool) Only present if we consider transaction to be trusted and so safe to spend from.
+ "blockhash": "hashvalue", (string) The block hash containing the transaction.
+ "blockindex": n, (numeric) The index of the transaction in the block that includes it.
+ "blocktime": xxx, (numeric) The block time in seconds since epoch (1 Jan 1970 GMT).
"txid": "transactionid", (string) The transaction id.
- "time" : ttt, (numeric) The transaction time in seconds since epoch (1 Jan 1970 GMT)
- "timereceived" : ttt, (numeric) The time received in seconds since epoch (1 Jan 1970 GMT)
+ "walletconflicts": [ (array) Conflicting transaction ids.
+ "txid", (string) The transaction id.
+ ...
+ ],
+ "time": xxx, (numeric) The transaction time in seconds since epoch (midnight Jan 1 1970 GMT).
+ "timereceived": xxx, (numeric) The time received in seconds since epoch (midnight Jan 1 1970 GMT).
+ "comment": "...", (string) If a comment is associated with the transaction, only present if not empty.
"bip125-replaceable": "yes|no|unknown", (string) Whether this transaction could be replaced due to BIP125 (replace-by-fee);
may be unknown for unconfirmed transactions not in the mempool
"details" : [
{
+ "involvesWatchonly": xxx, (bool) Only returns true if imported addresses were involved in transaction.
"address" : "address", (string) The bitcoin address involved in the transaction
"category" : (string) The transaction category.
"send" Transactions sent.
"receive" Non-coinbase transactions received.
"generate" Coinbase transactions received with more than 100 confirmations.
"immature" Coinbase transactions received with 100 or fewer confirmations.
"orphan" Orphaned coinbase transactions received.
"amount" : x.xxx, (numeric) The amount in BTC
"label" : "label", (string) A comment for the address/transaction, if any
"vout" : n, (numeric) the vout value
"fee": x.xxx, (numeric) The amount of the fee in BTC. This is negative and only available for the
'send' category of transactions.
"abandoned": xxx (bool) 'true' if the transaction has been abandoned (inputs are respendable). Only available for the
'send' category of transactions.
}
,...
],
"hex" : "data" (string) Raw data for transaction
"decoded" : transaction (json object) Optional, the decoded transaction (only present when `verbose` is passed), equivalent to the
- RPC decoderawtransaction method, or the RPC getrawtransaction method when `verbose` is passed.
}
Examples:
diff --git a/listreceivedbyaddress b/listreceivedbyaddress
index 3e895f4..566ddb3 100644
--- a/listreceivedbyaddress
+++ b/listreceivedbyaddress
@@ -11,15 +11,15 @@ Arguments:
Result:
[
{
- "involvesWatchonly" : true, (bool) Only returned if imported addresses were involved in transaction
+ "involvesWatchonly" : true, (bool) Only returns true if imported addresses were involved in transaction.
"address" : "receivingaddress", (string) The receiving address
"amount" : x.xxx, (numeric) The total amount in BTC received by the address
"confirmations" : n, (numeric) The number of confirmations of the most recent transaction included
"label" : "label", (string) The label of the receiving address. The default label is "".
"txids": [
"txid", (string) The ids of transactions received with the address
...
]
}
,...
]
diff --git a/listreceivedbylabel b/listreceivedbylabel
index 38d25bf..d716f9b 100644
--- a/listreceivedbylabel
+++ b/listreceivedbylabel
@@ -10,10 +10,10 @@ Arguments:
Result:
[
{
- "involvesWatchonly" : true, (bool) Only returned if imported addresses were involved in transaction
+ "involvesWatchonly" : true, (bool) Only returns true if imported addresses were involved in transaction.
"amount" : x.xxx, (numeric) The total amount received by addresses with this label
"confirmations" : n, (numeric) The number of confirmations of the most recent transaction included
"label" : "label" (string) The label of the receiving address. The default label is "".
}
,...
]
diff --git a/listsinceblock b/listsinceblock
index be347aa..54f4fbf 100644
--- a/listsinceblock
+++ b/listsinceblock
@@ -14,35 +14,43 @@ Arguments:
Result:
{
"transactions": [
+ "involvesWatchonly": xxx, (bool) Only returns true if imported addresses were involved in transaction.
"address":"address", (string) The bitcoin address of the transaction.
"category": (string) The transaction category.
"send" Transactions sent.
"receive" Non-coinbase transactions received.
"generate" Coinbase transactions received with more than 100 confirmations.
"immature" Coinbase transactions received with 100 or fewer confirmations.
"orphan" Orphaned coinbase transactions received.
"amount": x.xxx, (numeric) The amount in BTC. This is negative for the 'send' category, and is positive
for all other categories
"vout" : n, (numeric) the vout value
"fee": x.xxx, (numeric) The amount of the fee in BTC. This is negative and only available for the 'send' category of transactions.
- "confirmations": n, (numeric) The number of confirmations for the transaction.
- When it's < 0, it means the transaction conflicted that many blocks ago.
+ "confirmations": n, (numeric) The number of confirmations for the transaction. Negative confirmations indicate the
+ transaction conflicts with the block chain.
+ "generated": xxx, (bool) Only present if transaction only input is a coinbase one.
+ "trusted": xxx, (bool) Only present if we consider transaction to be trusted and so safe to spend from.
"blockhash": "hashvalue", (string) The block hash containing the transaction.
"blockindex": n, (numeric) The index of the transaction in the block that includes it.
"blocktime": xxx, (numeric) The block time in seconds since epoch (1 Jan 1970 GMT).
"txid": "transactionid", (string) The transaction id.
- "time": xxx, (numeric) The transaction time in seconds since epoch (Jan 1 1970 GMT).
- "timereceived": xxx, (numeric) The time received in seconds since epoch (Jan 1 1970 GMT).
+ "walletconflicts": [ (array) Conflicting transaction ids.
+ "txid", (string) The transaction id.
+ ...
+ ],
+ "time": xxx, (numeric) The transaction time in seconds since epoch (midnight Jan 1 1970 GMT).
+ "timereceived": xxx, (numeric) The time received in seconds since epoch (midnight Jan 1 1970 GMT).
+ "comment": "...", (string) If a comment is associated with the transaction, only present if not empty.
"bip125-replaceable": "yes|no|unknown", (string) Whether this transaction could be replaced due to BIP125 (replace-by-fee);
may be unknown for unconfirmed transactions not in the mempool
"abandoned": xxx, (bool) 'true' if the transaction has been abandoned (inputs are respendable). Only available for the 'send' category of transactions.
"comment": "...", (string) If a comment is associated with the transaction.
"label" : "label" (string) A comment for the address/transaction, if any
"to": "...", (string) If a comment to is associated with the transaction.
],
"removed": [
<structure is the same as "transactions" above, only present if include_removed=true>
Note: transactions that were re-added in the active chain will appear as-is in this array, and may thus have a positive confirmation count.
],
"lastblock": "lastblockhash" (string) The hash of the block (target_confirmations-1) from the best block on the main chain. This is typically used to feed back into listsinceblock the next time you call it. So you would generally use a target_confirmations of say 6, so you will be continually re-notified of transactions until they've reached 6 confirmations plus any new ones
}
diff --git a/listtransactions b/listtransactions
index 438677e..63249dc 100644
--- a/listtransactions
+++ b/listtransactions
@@ -14,32 +14,38 @@ Arguments:
Result:
[
{
+ "involvesWatchonly": xxx, (bool) Only returns true if imported addresses were involved in transaction.
"address":"address", (string) The bitcoin address of the transaction.
"category": (string) The transaction category.
"send" Transactions sent.
"receive" Non-coinbase transactions received.
"generate" Coinbase transactions received with more than 100 confirmations.
"immature" Coinbase transactions received with 100 or fewer confirmations.
"orphan" Orphaned coinbase transactions received.
"amount": x.xxx, (numeric) The amount in BTC. This is negative for the 'send' category, and is positive
for all other categories
"label": "label", (string) A comment for the address/transaction, if any
"vout": n, (numeric) the vout value
"fee": x.xxx, (numeric) The amount of the fee in BTC. This is negative and only available for the
'send' category of transactions.
"confirmations": n, (numeric) The number of confirmations for the transaction. Negative confirmations indicate the
- transaction conflicts with the block chain
- "trusted": xxx, (bool) Whether we consider the outputs of this unconfirmed transaction safe to spend.
+ transaction conflicts with the block chain.
+ "generated": xxx, (bool) Only present if transaction only input is a coinbase one.
+ "trusted": xxx, (bool) Only present if we consider transaction to be trusted and so safe to spend from.
"blockhash": "hashvalue", (string) The block hash containing the transaction.
"blockindex": n, (numeric) The index of the transaction in the block that includes it.
"blocktime": xxx, (numeric) The block time in seconds since epoch (1 Jan 1970 GMT).
"txid": "transactionid", (string) The transaction id.
+ "walletconflicts": [ (array) Conflicting transaction ids.
+ "txid", (string) The transaction id.
+ ...
+ ],
"time": xxx, (numeric) The transaction time in seconds since epoch (midnight Jan 1 1970 GMT).
"timereceived": xxx, (numeric) The time received in seconds since epoch (midnight Jan 1 1970 GMT).
- "comment": "...", (string) If a comment is associated with the transaction.
+ "comment": "...", (string) If a comment is associated with the transaction, only present if not empty.
"bip125-replaceable": "yes|no|unknown", (string) Whether this transaction could be replaced due to BIP125 (replace-by-fee);
may be unknown for unconfirmed transactions not in the mempool
"abandoned": xxx (bool) 'true' if the transaction has been abandoned (inputs are respendable). Only available for the
'send' category of transactions.
}
] |
maflcko
reviewed
Oct 9, 2019
| " ],\n" | ||
| " \"hex\" : \"data\" (string) Raw data for transaction\n" | ||
| " \"decoded\" : transaction (json object) Optional, the decoded transaction (only present when `verbose` is passed), equivalent to the\n" | ||
| " RPC decoderawtransaction method, or the RPC getrawtransaction method when `verbose` is passed.\n" |
maflcko
reviewed
Oct 9, 2019
| " ...\n" | ||
| " ],\n" | ||
| " \"time\": xxx, (numeric) The transaction time in seconds since epoch (midnight Jan 1 1970 GMT).\n" | ||
| " \"timereceived\": xxx, (numeric) The time received in seconds since epoch (midnight Jan 1 1970 GMT).\n" |
There was a problem hiding this comment.
I'd say to remove midnight, because we don't use that nomenclature anywhere else
maflcko
reviewed
Oct 9, 2019
|
ACK 396da1d Show signature and timestampSignature: Timestamp of file with hash |
added 2 commits
October 9, 2019 14:22
Fields involvesWatchonly, generated, walletconflicts were missing in result description of listtransactions, listsinceblock, gettransaction Align getttransaction fields which were odd compare to other rpc helpers
ariard
force-pushed
the
2019-08-missing-fields-rpcs-help
branch
from
396da1d to
f4c8953
Compare
|
re-ACK f4c8953 (only change is addressing my nits) Show signature and timestampSignature: Timestamp of file with hash |
kristapsk
approved these changes
Oct 10, 2019
maflcko
pushed a commit
that referenced
this pull request
Oct 10, 2019
f4c8953 Add missing fields in TransactionDescriptionString and others (Antoine Riard) 3530108 MOVEONLY : move RPC wallets helpers to TransactionDescriptionString (Antoine Riard) Pull request description: Knowledge of `walletconflicts` field existence is really nice when you're debugging conflicts. Was added in #3671 but never documented in RPC helps. Others were added after a quick skim, we may still have missing ones in wallet rpcs. ACKs for top commit: MarcoFalke: re-ACK f4c8953 (only change is addressing my nits) kristapsk: ACK f4c8953 Tree-SHA512: 2bea4d8743399fb152f942df7454548b896b2ad5654fd4bf60253afec1a5387ef8797ced97776dc7ba4912291263c08abe7c2b608c6a28f9a0df67be4ebc4635
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Nov 17, 2019
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 8, 2020
…onDescriptionString Summary: bitcoin/bitcoin@3530108 --- Partial backport of Core [[bitcoin/bitcoin#16689 | PR16689]] Test Plan: ninja bitcoin-cli help listtransactions|listsinceblock|gettransaction Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D7384
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 8, 2020
…ng and others Summary: Fields involvesWatchonly, generated, walletconflicts were missing in result description of listtransactions, listsinceblock, gettransaction Align getttransaction fields which were odd compare to other rpc helpers bitcoin/bitcoin@f4c8953 --- Depends on D7384 Concludes backport of Core [[bitcoin/bitcoin#16689 | PR16689]] Test Plan: ninja bitcoin-cli help listreceivedbyaddress|listreceivedbylabel|listtransactions|listsinceblock|gettransaction Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D7385
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Knowledge of
walletconflictsfield existence is really nice when you're debugging conflicts. Was added in #3671 but never documented in RPC helps.Others were added after a quick skim, we may still have missing ones in wallet rpcs.