test: Add missed header

[hebasto]

Should fix MSVC link errors like that:

addressbooktests.obj : error LNK2019: unresolved external symbol "void __cdecl ConfirmMessage(class QString *,class std::chrono::duration<__int64,struct std::ratio<1,1000> >)" (?ConfirmMessage@@YAXPEAVQString@@V?$duration@_JU?$ratio@$00$0DOI@@std@@@chrono@std@@@Z) referenced in function "void __cdecl `anonymous namespace'::EditAddressAndSubmit(class EditAddressDialog *,class QString const &,class QString const &,class QString)" (?EditAddressAndSubmit@?A0x2e52698e@@YAXPEAVEditAddressDialog@@AEBVQString@@1V3@@Z) [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\build_msvc\test_bitcoin-qt\test_bitcoin-qt.vcxproj]
wallettests.obj : error LNK2001: unresolved external symbol "void __cdecl ConfirmMessage(class QString *,class std::chrono::duration<__int64,struct std::ratio<1,1000> >)" (?ConfirmMessage@@YAXPEAVQString@@V?$duration@_JU?$ratio@$00$0DOI@@std@@@chrono@std@@@Z) [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\build_msvc\test_bitcoin-qt\test_bitcoin-qt.vcxproj]
C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\build_msvc\x64\Release\test_bitcoin-qt.exe : fatal error LNK1120: 1 unresolved externals [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\build_msvc\test_bitcoin-qt\test_bitcoin-qt.vcxproj]

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #650 (Add Import to Wallet GUI by KolbyML)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[hebasto]

cc @fanquake @sipsorcery

[fanquake]

ACK 36e2d51

[maflcko]

Any understanding why or when this happened?

[fanquake]

I think it was bitcoin/bitcoin#26715.

[maflcko]

But CI passed on the pull and merge commit (https://github.com/bitcoin/bitcoin/runs/13481551706), no?

[hebasto]

The MSVC link issue was kind of intermittent. I guess, it was dependent on the actual order of processing of the source files.

[maflcko]

Ok, interesting. Maybe with iwyu this kind of bug will be fixed eventually 🥲

[fanquake]

Yea. I guess the compiler is broken? Developers should not have to worry about putting files in the "right order" for it.

[hebasto]

Observing the same issue -- https://cirrus-ci.com/task/6646912535756800

:(

[maflcko]

Anything holding back bitcoin/bitcoin#27571 ?

[fanquake]

No.

[maflcko]

Looks like iwyu doesn't work with qt?

(qt/test/util.h has correct #includes/fwd-decls)

qt/test/util.cpp should add these lines:
#include <QtCore/qobjectdefs.h>  // for FunctionPointer<>::IsPointerToMember...
#include <qapplication.h>        // for QApplication
#include <qlist.h>               // for QList
#include <qmessagebox.h>         // for QMessageBox
#include <qobject.h>             // for qobject_cast
#include <qpushbutton.h>         // for QPushButton
#include <qstring.h>             // for QString
#include <qtimer.h>              // for QTimer
#include <qwidget.h>             // for QWidget
#include <utility>               // for move

qt/test/util.cpp should remove these lines:
- #include <QApplication>  // lines 9-9
- #include <QMessageBox>  // lines 10-10
- #include <QPushButton>  // lines 11-11
- #include <QString>  // lines 12-12
- #include <QTimer>  // lines 13-13
- #include <QWidget>  // lines 14-14

[fanquake]

Looks like iwyu doesn't work with qt?

We might have to provide a mapping file, for it to work sanely? i.e https://github.com/include-what-you-use/include-what-you-use/blob/master/qt5_11.imp.

[hebasto]

Looks like iwyu doesn't work with qt?

We might have to provide a mapping file, for it to work sanely? i.e include-what-you-use/include-what-you-use@master/qt5_11.imp.

Added in bitcoin/bitcoin#27710.