Disable the main window toolbar when the modal overlay is shown #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested ACK d0cc1f6. Tested on Linux/X11 as much as I could given it's a pretty small change; seems like a nice improvement. I'm not experienced in Qt, but I don't see anything obviously problematic about the code. |
|
Tested ACK. Tested on Ubuntu 20.04 LTS. It can improve user experience. |
LarryRuane
approved these changes
Jul 13, 2020
There was a problem hiding this comment.
ACK d0cc1f6 tested on Ubuntu 18.04.4 LTS
I didn't review the code but verified the behavior with and without the PR, and that src/qt/test/test_bitcoin-qt passes.
|
Not sure whether it's still helpful but I tested it on MacOS and confirm it worked as well, nicely done @hebasto |
|
@polylunar thanks! It is very helpful to review before or after a merge. Great to see and looking forward to more tests and review from you 🚀 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jul 14, 2020
…odal overlay is shown d0cc1f6 qt: Disable toolbar when overlay is shown (Hennadii Stepanov) e74cd20 qt, refactor: Cleanup ModalOverlay slots (Hennadii Stepanov) Pull request description: Keeping the main window toolbar activated while the modal overlay is shown could create the appearance of the non-responsive GUI. Fixes #22. --- On master (ca05588):  With this PR:  ACKs for top commit: harding: Tested ACK d0cc1f6. Tested on Linux/X11 as much as I could given it's a pretty small change; seems like a nice improvement. I'm not experienced in Qt, but I don't see anything obviously problematic about the code. jonatack: ACK d0cc1f6 tested on Debian 5.7.6-1 (2020-06-24) x86_64 GNU/Linux LarryRuane: ACK d0cc1f6 tested on Ubuntu 18.04.4 LTS Tree-SHA512: e371b34231c01e77118deb100e0f280ba1cdef54e317f7f7d6ac322598bda811bd1bfe3035e90d87f8267f4f5d2095d34a8136911159db63694fd1b1b11335a1
apoelstra
added a commit
to apoelstra/elements
that referenced
this pull request
Dec 3, 2020
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Mar 19, 2021
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Aug 31, 2021
Summary: > qt, refactor: Cleanup ModalOverlay slots > qt: Disable toolbar when overlay is shown This is a backport of [[bitcoin-core/gui#30 | core-gui#30]] Test Plan: `bitcoin-qt --regtest Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D9994
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping the main window toolbar activated while the modal overlay is shown could create the appearance of the non-responsive GUI.
Fixes #22.
On master (ca05588):
With this PR: