Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt: Add Copy Address Action to Payment Requests #213

Merged
merged 1 commit into from
Feb 23, 2021
Merged

qt: Add Copy Address Action to Payment Requests #213

merged 1 commit into from
Feb 23, 2021

Conversation

jarolrod
Copy link
Member

Currently, the only way to copy the address of a payment request is to double-click on the payment request and then click on the copy address button. This PR adds a convenient context menu action to copy the address of a payment request.

Master PR
Screen Shot 2021-02-18 at 8 33 08 PM Screen Shot 2021-02-18 at 8 33 50 PM

@jarolrod jarolrod mentioned this pull request Feb 19, 2021
Merged
Talkless
Talkless suggested changes Feb 20, 2021
View reviewed changes
@jarolrod jarolrod force-pushed the add-copyaddress-requestedpayments branch from 405215f to 24fcd97 Compare February 22, 2021 01:23
@jarolrod
Copy link
Member Author

jarolrod commented Feb 22, 2021 •
edited
Loading

Updated from 405215f -> 24fcd97, addressed @Talkless suggestion

Changes:

  • sel is now const

@hebasto
Copy link
Member

hebasto commented Feb 22, 2021

Concept ACK. I've noted the same inconvenience :)

@hebasto
Copy link
Member

hebasto commented Feb 22, 2021

@jarolrod

This pr, which is submitted on 2021-02-19, is based on the branch commit from 2020-11-05. While it has no ACKs, maybe rebase it to eliminate CI glitches?

@jarolrod jarolrod force-pushed the add-copyaddress-requestedpayments branch from 24fcd97 to 8871d9a Compare February 22, 2021 16:21
@jarolrod
Copy link
Member Author

Updated from 24fcd97 -> 8871d9a

Changes: Rebased to a more recent master branch in order to avoid CI glitches on @hebasto recommendation

hebasto
hebasto approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8871d9a, tested on Linux Mint 20.1 (Qt 5.12.8).

@jarolrod
qt: Add Copy Address Action to Payment Requests
e348d7e 
Currently, the only way to copy the address of a payment request is to double-click on the payment request and then click on the copy address button. This commit adds a convenient context menu action to copy the address of a payment request.
@jarolrod jarolrod force-pushed the add-copyaddress-requestedpayments branch from 8871d9a to e348d7e Compare February 23, 2021 05:01
@jarolrod
Copy link
Member Author

Updated from 8871d9a -> e348d7e

Changes:

hebasto
hebasto approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK e348d7e, only suggested changes since my previous review.

@maflcko maflcko merged commit d386b54 into bitcoin-core:master Feb 23, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Feb 23, 2021
Merge bitcoin-core/gui#213: qt: Add Copy Address Action to Payment Re…
e5e032b 
…quests

e348d7e qt: Add Copy Address Action to Payment Requests (Jarol Rodriguez)

Pull request description:

  Currently, the only way to copy the address of a payment request is to double-click on the payment request and then click on the copy address button. This PR adds a convenient context menu action to copy the address of a payment request.

  | Master        | PR                 |
  | ----------- | ------------ |
  |<img width="169" alt="Screen Shot 2021-02-18 at 8 33 08 PM" src="https://user-images.githubusercontent.com/23396902/108444489-b6703f80-7228-11eb-8684-945fbcd04772.png"> |<img width="169" alt="Screen Shot 2021-02-18 at 8 33 50 PM" src="https://user-images.githubusercontent.com/23396902/108444505-c12ad480-7228-11eb-9eee-473fee877ad7.png">|

ACKs for top commit:
  hebasto:
    re-ACK e348d7e, only suggested changes since my [previous](bitcoin-core/gui#213 (review)) review.

Tree-SHA512: 2b75930ca326ef1d695afc1c6f25853ef55d06d20b66c3c3c372188a6cdfa4686c07f9c56824b766e46b660c731f8a9c2e5b935aa26b316fd46f9e396b29b802
@jarolrod jarolrod deleted the add-copyaddress-requestedpayments branch February 23, 2021 19:38
maflcko pushed a commit that referenced this pull request Feb 25, 2021
Merge #214: qt: Disable requests context menu actions when appropriate
09bc7bf 
bb3da8f qt: Disable requests context menu actions when appropriate (Jarol Rodriguez)

Pull request description:

  The recent requests table will allow you to copy data points even if they do not exist. This PR implements checks to disable the `copy label`, `copy message`, and `copy amount` context menu actions if the respective fields are empty. This brings the recent requests table context menu behavior closer to the behavior seen in the transaction view.

  On a payment request entry which does not have a value for label, message, or amount:
  | Master        | PR               |
  | ----------- | ----------- |
  |<img width="169" alt="Screen Shot 2021-02-19 at 1 22 28 AM" src="https://user-images.githubusercontent.com/23396902/108466086-167adc00-7251-11eb-8bd6-13984042bdb3.png">| <img width="169" alt="Screen Shot 2021-02-19 at 1 21 49 AM" src="https://user-images.githubusercontent.com/23396902/108466185-3e6a3f80-7251-11eb-9dd8-492ed07fd638.png">|

  `copy URI` never needs to be disabled as an entry in the recent requests table must have a URI even if it doesn't have a label, message, or amount. #213 will add a `copy address` context menu action. This also does not need a check as an entry must be associated with an address.

  Below are some more examples of how this PR will behave:
  **Has Label, Message, and Amount**
  <img width="780" alt="Screen Shot 2021-02-19 at 12 05 38 AM" src="https://user-images.githubusercontent.com/23396902/108466507-c18b9580-7251-11eb-8875-f3aeb9c4c8e9.png">

  **Has Label and Amount, but no Message**
  <img width="780" alt="Screen Shot 2021-02-19 at 12 05 58 AM" src="https://user-images.githubusercontent.com/23396902/108466421-9b65f580-7251-11eb-97eb-a3bfaa21fa7d.png">

ACKs for top commit:
  hebasto:
    re-ACK bb3da8f

Tree-SHA512: d98f1a6e05ebf6d9d056bc5754aca78ca7ecda93f497dba88187b947ca4a261eb7dc5e8c872956315acaa0008cc39320fb5806e17117e0c873090ad917ca4a3d
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 17, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#213: qt: Add Copy Address Action to Payment Re…
a0bf9a6 
…quests

e348d7e qt: Add Copy Address Action to Payment Requests (Jarol Rodriguez)

Pull request description:

  Currently, the only way to copy the address of a payment request is to double-click on the payment request and then click on the copy address button. This PR adds a convenient context menu action to copy the address of a payment request.

  | Master        | PR                 |
  | ----------- | ------------ |
  |<img width="169" alt="Screen Shot 2021-02-18 at 8 33 08 PM" src="https://user-images.githubusercontent.com/23396902/108444489-b6703f80-7228-11eb-8684-945fbcd04772.png"> |<img width="169" alt="Screen Shot 2021-02-18 at 8 33 50 PM" src="https://user-images.githubusercontent.com/23396902/108444505-c12ad480-7228-11eb-9eee-473fee877ad7.png">|

ACKs for top commit:
  hebasto:
    re-ACK e348d7e, only suggested changes since my [previous](bitcoin-core/gui#213 (review)) review.

Tree-SHA512: 2b75930ca326ef1d695afc1c6f25853ef55d06d20b66c3c3c372188a6cdfa4686c07f9c56824b766e46b660c731f8a9c2e5b935aa26b316fd46f9e396b29b802
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 19, 2021
@PastaPastaPasta
Merge bitcoin-core/gui#213: qt: Add Copy Address Action to Payment Re…
44a0d7e 
…quests

e348d7e qt: Add Copy Address Action to Payment Requests (Jarol Rodriguez)

Pull request description:

  Currently, the only way to copy the address of a payment request is to double-click on the payment request and then click on the copy address button. This PR adds a convenient context menu action to copy the address of a payment request.

  | Master        | PR                 |
  | ----------- | ------------ |
  |<img width="169" alt="Screen Shot 2021-02-18 at 8 33 08 PM" src="https://user-images.githubusercontent.com/23396902/108444489-b6703f80-7228-11eb-8684-945fbcd04772.png"> |<img width="169" alt="Screen Shot 2021-02-18 at 8 33 50 PM" src="https://user-images.githubusercontent.com/23396902/108444505-c12ad480-7228-11eb-9eee-473fee877ad7.png">|

ACKs for top commit:
  hebasto:
    re-ACK e348d7e, only suggested changes since my [previous](bitcoin-core/gui#213 (review)) review.

Tree-SHA512: 2b75930ca326ef1d695afc1c6f25853ef55d06d20b66c3c3c372188a6cdfa4686c07f9c56824b766e46b660c731f8a9c2e5b935aa26b316fd46f9e396b29b802
thelazier pushed a commit to thelazier/dash that referenced this pull request Sep 25, 2021
@thelazier
Merge bitcoin-core/gui#213: qt: Add Copy Address Action to Payment Re…
df7a5a8 
…quests

e348d7e qt: Add Copy Address Action to Payment Requests (Jarol Rodriguez)

Pull request description:

  Currently, the only way to copy the address of a payment request is to double-click on the payment request and then click on the copy address button. This PR adds a convenient context menu action to copy the address of a payment request.

  | Master        | PR                 |
  | ----------- | ------------ |
  |<img width="169" alt="Screen Shot 2021-02-18 at 8 33 08 PM" src="https://user-images.githubusercontent.com/23396902/108444489-b6703f80-7228-11eb-8684-945fbcd04772.png"> |<img width="169" alt="Screen Shot 2021-02-18 at 8 33 50 PM" src="https://user-images.githubusercontent.com/23396902/108444505-c12ad480-7228-11eb-9eee-473fee877ad7.png">|

ACKs for top commit:
  hebasto:
    re-ACK e348d7e, only suggested changes since my [previous](bitcoin-core/gui#213 (review)) review.

Tree-SHA512: 2b75930ca326ef1d695afc1c6f25853ef55d06d20b66c3c3c372188a6cdfa4686c07f9c56824b766e46b660c731f8a9c2e5b935aa26b316fd46f9e396b29b802
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 28, 2022
@apoelstra
Merge d386b54 into merged_master (Bitcoin PR bitcoin-core/gui#213)
6cfd41b 
We had renamed the "Copy URI" GUI action to "Copy address"; Core added
a new "Copy address" action. So I deleted the old "Copy URI" action and
just kept the new "Copy address" one.
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Talkless Talkless Talkless requested changes

@hebasto hebasto hebasto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jarolrod @hebasto @Talkless @maflcko