Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass '--expert' and '--chain' cmd-line arguments to enumerate() functions #651

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

JamieDriver
Copy link
Contributor

These arguments are currently discarded/ignored for the enumerate command. Pass them through to the per-hw enumerate() calls.

In the Jade client, use the 'chain' parameter to enable testnet-configured Jade units to enumerate successfully.

@strangebit
Copy link

strangebit commented Dec 1, 2022

Thanks for this. For the maintainer, this came about because I was trying to set up Jade for use with Sparrow on testnet/signet, but was having trouble with the Jade returning JadeError: -32003 - Network type inconsistent with prior usage (Data: None). That was the case even though the Jade was properly previously initalized for testnet using the Blockstream Green Desktop client first.

We had a long discussion about it here: Blockstream/Jade#13 (comment). You can safely ignore anything above this part of the thread as not being relevant. When we got to trying out HWI via the CLI directly with --chain test, it seemed to work as expected with most commands like displayaddress, getxpub, etc. The breakthrough realization came here, which was that Sparrow was finding an error when enumerating devices after clicking 'Scan': Blockstream/Jade#13 (comment).

Two reasons for this are: A) HWI doesn't make use of the --chain argument when enumerating, which apparently the Jade needs to know or it will return an error, and B) Sparrow doesn't use the --chain argument when doing an enumerate call to HWI as well (which makes sense since it currently doesn't do anything anyway). Obviously only A is relevant to this PR, but I thought I'd mention B as well for extra clarity.

@JamieDriver
Copy link
Contributor Author

JamieDriver commented Dec 2, 2022

ALSO:

  • We could then only probe for 'simulators' if '--expert' was passed, and make sure the test framework passes that option.

…ions

These arguments are currently discarded/ignored for the enumerate
command.  Pass them through to the per-hw enumerate() calls.

In the Jade client, use the 'chain' parameter to enable
testnet-configured Jade units to enumerate successfully.

Also update error message to reflect latest wording on Jade hw.
@JamieDriver JamieDriver force-pushed the pass_args_to_enumerate branch from f4091f4 to f7e6126 Compare December 8, 2022 08:37
@achow101
Copy link
Member

achow101 commented Jan 3, 2023

ACK f7e6126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants