psbt: implement BIP 371 Taproot PSBT fields #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 19, 2021
achow101
force-pushed
the
taproot-psbt
branch
from
171a5fb to
1acb462
Compare
Track the set of keys that have been read in order to better catch duplicate keys. Matches Core's handling of duplicate keys.
Instead of using 0 as a magic number, make self.sighash an Optional.
Instead of including field numbers explicitly, use their names, with the numbers defined as static members of their respective classes.
Instead of serializing the field number explicitly as bytes, use the named members for the field numbers. Also serializes them with ser_compact_size in accordance with BIP 174
achow101
force-pushed
the
taproot-psbt
branch
from
1acb462 to
c5fba03
Compare
|
re-utACK c5fba03 |
achow101
added a commit
that referenced
this pull request
Feb 1, 2022
2669bce tests: each device explicitly lists signtx cases (Andrew Chow) b9093d1 trezor: Disallow external inputs when signing with tr (Andrew Chow) c37acd4 tests: Taproot signing tests (Andrew Chow) ab189db tests: Add Trezor to SUPPORTS_TAPROOT (Andrew Chow) 6ae50be trezor: Sign Taproot inputs (Andrew Chow) 9fe19f4 trezor: Allow taproot addresses for displayaddress (Andrew Chow) f168058 trezor: Implement can_sign_taproot (Andrew Chow) Pull request description: Implements Taproot support for Trezor devices. Depends on #545, #546, #547, and #548 No tests yet as they would need bitcoin/bitcoin#22558 merged into Bitcoin Core. Top commit has no ACKs. Tree-SHA512: 608e554efe459772465a4066679d108ae6e81f1063a3e4b67832140f199d7565ff46f13740a401875a2b54bc94828dbc77054b0203bdca93d4c439ee829d07eb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Taproot PSBT fields as described in BIP 371