keepkey, trezor: Handle if ButtonRequest is sent during sendpin #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keepkey is now displaying the passphrase to users after it receives it and responding with a ButtonRequest message. However this was not being properly handled by sendpin which would cause the device to hang as it waited for a ButtonAck. To resolve this, use self.call but avoid the firmware check which will fail due to the lack of self.features.
achow101
force-pushed
the
keepkey-pass-confirm
branch
from
0d31d78 to
2fa0c94
Compare
|
Oh, interesting, I didn't realize that #539 was basically the same problem. I've updated this to actually handle all the callbacks correctly. |
Keepkey and Trezor had firmware changes that made sendpin not work when passphrase protection was enabled and a passphrase was provided. Modify the test to check for this case.
|
Hi @prusnak, I can verify that this patch works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keepkey and Trezor may ask the user for confirmation of their passphrase after the PIN is sent. This could cause some issues as
ButtonRequestswere not being handled bysendpin. Additionally,TrezorClient.callwould not work because it needs access toTrezorClient.features, which is not set for thesendpincommand. In order to resolve this,TrezorClient.callis modified to optionally skip the firmware check that requiresTrezorClient.features, andsendpinusesTrezorClient.callinstead ofTrezorClient.call_raw.Fixes #526
Fixes $539