test: Fix label tests #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achow101
force-pushed
the
fix-trezor-label-test
branch
from
b2ab5ae to
a39a741
Compare
achow101
force-pushed
the
fix-trezor-label-test
branch
from
a39a741 to
6b043d3
Compare
prusnak
reviewed
Oct 24, 2021
| result = self.do_command(self.dev_args + ['enumerate']) | ||
| for dev in result: | ||
| if dev['type'] == 'trezor' and dev['path'] == 'udp:127.0.0.1:11044': | ||
| self.assertEqual(result['label'], 'HWI Keepkey') | ||
| if dev['type'] == 'keepkey' and dev['path'] == 'udp:127.0.0.1:11044': |
There was a problem hiding this comment.
No, those are actually incorrect! I've added a commit that fixes them and will cause the tests to fail if these are incorrect.
There are a number of trezor and keepkey tests which rely on enumerate and then looking at the enumerated results. However some are looking for the wrong thing and inadverdently doing nothing. So extra checks are added to make sure they are actually doing something.
|
Merging as CI passed |
prusnak
reviewed
Oct 25, 2021
| @@ -285,20 +297,30 @@ def test_passphrase(self): | |||
|
|
|||
| # A passphrase will need to be sent | |||
| result = self.do_command(self.dev_args + ['enumerate']) | |||
| print(result) | |||
There was a problem hiding this comment.
I think you forgot to remove this debug line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests weren't working. Also fixed another keepkey test bug.