Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oct 2021 Dependency Update #531

Merged
merged 5 commits into from
Oct 21, 2021

Conversation

achow101
Copy link
Member

Updates our dependencies to the latest. There were a few major releases, but nothing that appears to affect our usage of those dependencies.

Notable changes

  • Python <3.10 restriction is removed. This was to allow pyside2, but I have pyside2 to only be installed if python <3.10 rather than having the restriction be global
  • libusb1 is bumped to 2.0+. It seems like they just dropped python 3.4 so needed to bump the major version.
  • pefile, macholib, and pywin32-ctypes are pyinstaller dependencies that were added because pyinstaller had specified them in a way poetry did not detect. They have fixed that since 4.0, so these are dropped.

The dev dependencies pywin32-ctypes, pefile, and macholib were added
because poetry had issues detecting that pyinstaller needed these
dependencies. But pyinstaller has fixed that since 4.0, so we don't need
to keep them around.
This restriction was because pyside2 has a restriction on python <3.10.
As pyside2 is optional, and the binary builds are done with 3.7, it is
okay to remove this restriction globally and just limit it to pyside2
itself. So pyside2 will only be installed if the qt extra is specified,
and python <3.10.
The developer dependency restrictions don't need to be very strict.
These are relaxed as well as bumped to their current major versions.
libusb1 has 2.x releases.
@achow101
Copy link
Member Author

There appears to be some unrelated, lingering CI issues. However the tests for everything else works, so merging this.

@achow101 achow101 merged commit 18b89a6 into bitcoin-core:master Oct 21, 2021
achow101 added a commit that referenced this pull request Oct 26, 2021
a8f955a tests: Remove extraneous debug line (Andrew Chow)
8f6b7e9 deps: regenerate setup.py (Andrew Chow)
8719bfe deps: regenerate poetry.lock (Andrew Chow)
3fde13e deps: Allow older versions (Andrew Chow)

Pull request description:

  After #531, we updated dependencies but accidentally removed support for older versions that aren't actually incompatible with our usage. So re-allow those. Also regenerates the setup.py which I forgot to do.

  Closes #537

Top commit has no ACKs.

Tree-SHA512: 86e520c8444a1cd9985beb0a4a0081d07d6e4d4fce958fd133743c20cafb07bf9fa31927308e7519a4fdf3b287d4c2d8de02a8160cc9d24d9ce8f535b07f017f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant