Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Pyenv's Python to 3.9 #494

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Conversation

Sjors
Copy link
Member

@Sjors Sjors commented Mar 16, 2021

Since the release notes mention support for Python 3.9. Or do we also want to guarantee backwards compatibility?

Using 3.9.1 for PyEnv (latest available on macOS) and 3.9.2 for the Windows installer.

@Sjors Sjors force-pushed the 2021/03/python-3.9 branch from c16f726 to 5fa94e0 Compare March 16, 2021 09:55
@Sjors
Copy link
Member Author

Sjors commented Mar 16, 2021

Seeing some timeouts.

@achow101
Copy link
Member

We want to guarantee backwards compatibility so everything should still use the oldest python version supported. The release note is just mentioning that people using Python 3.9 in their projects will be able to use HWI.

@Sjors Sjors force-pushed the 2021/03/python-3.9 branch from 5fa94e0 to 4398c1b Compare March 16, 2021 18:14
@Sjors Sjors changed the title Bump Python to 3.9 Bump Pyenv's Python to 3.9 Mar 16, 2021
@Sjors
Copy link
Member Author

Sjors commented Mar 16, 2021

Ok, in that case I think it's sufficient to bump .python-version for PyEnv users.

@Sjors Sjors force-pushed the 2021/03/python-3.9 branch from 4398c1b to 45d706d Compare March 16, 2021 18:16
@Sjors Sjors force-pushed the 2021/03/python-3.9 branch 2 times, most recently from 3ab34e8 to 6ee717c Compare April 26, 2021 13:04
@Sjors
Copy link
Member Author

Sjors commented Apr 26, 2021

Some confusing CI failings.

@achow101
Copy link
Member

achow101 commented Nov 9, 2021

Now that we have CI for all current python minor versions, we can bump pyenv and the build python versions to something more recent. Can you please rebase this and bump to more recent python?

@Sjors Sjors force-pushed the 2021/03/python-3.9 branch from 6ee717c to 3117eb4 Compare November 11, 2021 14:42
@Sjors
Copy link
Member Author

Sjors commented Nov 11, 2021

Done, let's see how 3.9.7 fares (3.9.8 isn't available on Homebrew yet, so Cirrus CI probably also won't have it)

@Sjors
Copy link
Member Author

Sjors commented Nov 19, 2021

The three test failures seem to be due to a timeout.

.cirrus.yml Outdated
@@ -214,6 +214,7 @@ dist_builder_task:
container:
dockerfile: contrib/build.Dockerfile
build_script:
- pyenv install 3.9.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contrib/build.Dockerfile should be changed instead of cirrus.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this line be dropped entirely then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@achow101
Copy link
Member

contrib/build_wine.sh should also be updated to use 3.9.7

@Sjors Sjors force-pushed the 2021/03/python-3.9 branch 2 times, most recently from 576df23 to 0b81e60 Compare November 19, 2021 18:14
HWI is compatible with Python 3.9.

Although 3.9.8 has been released, the most recent version of Python shipped
with PyEnv on homebrew (macOS) is 3.9.7

In order to test backwareds compatibility, the version is not changed elsewhere.
@Sjors Sjors force-pushed the 2021/03/python-3.9 branch from 0b81e60 to d1055df Compare November 19, 2021 18:28
@achow101
Copy link
Member

ACK d1055df

@achow101 achow101 merged commit a109bcd into bitcoin-core:master Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants