-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Pyenv's Python to 3.9 #494
Conversation
c16f726
to
5fa94e0
Compare
Seeing some timeouts. |
We want to guarantee backwards compatibility so everything should still use the oldest python version supported. The release note is just mentioning that people using Python 3.9 in their projects will be able to use HWI. |
5fa94e0
to
4398c1b
Compare
Ok, in that case I think it's sufficient to bump |
4398c1b
to
45d706d
Compare
3ab34e8
to
6ee717c
Compare
Some confusing CI failings. |
Now that we have CI for all current python minor versions, we can bump pyenv and the build python versions to something more recent. Can you please rebase this and bump to more recent python? |
6ee717c
to
3117eb4
Compare
Done, let's see how 3.9.7 fares (3.9.8 isn't available on Homebrew yet, so Cirrus CI probably also won't have it) |
The three test failures seem to be due to a timeout. |
.cirrus.yml
Outdated
@@ -214,6 +214,7 @@ dist_builder_task: | |||
container: | |||
dockerfile: contrib/build.Dockerfile | |||
build_script: | |||
- pyenv install 3.9.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contrib/build.Dockerfile
should be changed instead of cirrus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this line be dropped entirely then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
576df23
to
0b81e60
Compare
HWI is compatible with Python 3.9. Although 3.9.8 has been released, the most recent version of Python shipped with PyEnv on homebrew (macOS) is 3.9.7 In order to test backwareds compatibility, the version is not changed elsewhere.
0b81e60
to
d1055df
Compare
ACK d1055df |
Since the release notes mention support for Python 3.9. Or do we also want to guarantee backwards compatibility?
Using 3.9.1 for PyEnv (latest available on macOS) and 3.9.2 for the Windows installer.