BUGFIX: Editor loads scripts at wrong time #1867
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test scripts:
test.ts
lib.ts
How to reproduce this bug:
nano test.ts
.loadAllServerScripts
is called inparseCode
. There are 2 problems:loadAllServerScripts
is called every time the player edits their code. This means that it's called after every keystroke.parseCode
is still too late. It needs to be called much earlier. The start ofonMount
is a proper place. I also call it inonTabClick
. It may be useful if something else (via NS APIs or RFA) changes (add/edit/delete) scripts. For example, if an external editor pushes a script via RFA, we will load that new script when the player switches tabs. Technically, doing that indebouncedCodeParsing
may be better, but I think it's overkill.