Revert "Cleaned up ingestion"

[neilnaveen]

Reverts #117

Summary by CodeRabbit

• New Features

  • Introduced new command-line interfaces for graphing and loading vulnerability and scorecard data.
  • Enhanced SBOM ingestion process with progress reporting.
  • Added functionality for loading vulnerabilities and scorecards directly from storage.

• Bug Fixes

  • Improved error handling and reporting during data ingestion processes.

• Refactor

  • Streamlined data loading functions and test cases for better clarity and maintainability.

• Tests

  • Added new test cases for validating vulnerability and SBOM ingestion processes.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces significant modifications across multiple files related to data ingestion processes, particularly focusing on handling SBOM and vulnerability data. Key changes include the replacement of existing data loading methods with new functions that offer improved error handling and progress reporting. New command-line interface files for graphing vulnerability and scorecard data have been added, while existing command structures have been updated to delegate tasks more effectively. Overall, the changes streamline the ingestion process and enhance the clarity and maintainability of the codebase.

Changes

File Path	Change Summary
api/v1/service_test.go	Updated TestQueriesAndCache to replace LoadDataFromPath with SBOM, and modified vulnerability loading from Vulnerabilities to LoadVulnerabilities.
cmd/ingest/osv/graph/graph.go	Introduced new CLI command for graphing vulnerability data, including options struct and progress reporting.
cmd/ingest/osv/load/load.go	Added new package for loading vulnerability data, with command setup and progress reporting functionality.
cmd/ingest/osv/osv.go	Removed options struct and updated command structure to delegate loading and graphing functionalities to subcommands.
cmd/ingest/sbom/sbom.go	Simplified Run method to directly call ingest.SBOM, enhancing progress reporting.
cmd/ingest/scorecard/graph/graph.go	Introduced new CLI command for graphing scorecard data, including options struct and progress reporting.
cmd/ingest/scorecard/load/load.go	New package for loading scorecard data with command setup and progress reporting.
cmd/ingest/scorecard/scorecard.go	Updated command structure to focus on scorecard data ingestion, adding subcommands for loading and graphing.
pkg/storages/e2e_test.go	Refactored TestParseAndExecute_E2E to utilize new ingestion methods, enhancing error handling and clarity.
pkg/tools/ingest/loader.go	Updated LoadDataFromPath and processZipFile signatures for enhanced flexibility and progress reporting; added processJSONFile function.
pkg/tools/ingest/sbom.go	Modified SBOM function to handle both files and directories with improved error handling and progress tracking.
pkg/tools/ingest/sbom_test.go	Added test case for invalid SBOM file and updated loading logic to use the new SBOM function directly.
pkg/tools/ingest/scorecard.go	Updated Scorecards function to ingest data from storage, adding progress tracking and error handling improvements.
pkg/tools/ingest/vuln.go	Restructured Vulnerabilities function to retrieve data from storage and added LoadVulnerabilities for processing byte arrays.
pkg/tools/ingest/vuln_test.go	Introduced TestVulnerabilitiesToStorage for loading vulnerabilities into mock storage, enhancing clarity and error handling in tests.

Possibly related PRs

• Cleaned up ingestion #117: The changes in this PR involve modifying the SBOM ingestion process to utilize LoadDataFromPath, which aligns with the main PR's updates to the test suite in api/v1/service_test.go that also reflect a shift towards using LoadDataFromPath for loading data.

Suggested reviewers

• naveensrinivasan

🐇 In the code we hop and play,
With SBOMs and vulnerabilities at bay.
New commands we craft with care,
Progress and errors, we now declare.
So let’s load and graph, oh what a sight,
Data ingested, everything feels right! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 26.62338% with 113 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
pkg/tools/ingest/loader.go	0.00%	37 Missing ⚠️
pkg/tools/ingest/scorecard.go	0.00%	36 Missing ⚠️
pkg/tools/ingest/vuln.go	39.02%	16 Missing and 9 partials ⚠️
pkg/tools/ingest/sbom.go	62.50%	10 Missing and 5 partials ⚠️

Files with missing lines	Coverage Δ
pkg/tools/ingest/sbom.go	59.25% <62.50%> (+11.43%)	⬆️
pkg/tools/ingest/vuln.go	59.18% <39.02%> (-4.67%)	⬇️
pkg/tools/ingest/scorecard.go	0.00% <0.00%> (ø)
pkg/tools/ingest/loader.go	0.00% <0.00%> (-29.34%)	⬇️