Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 10 #482

Closed
dmos62 opened this issue Feb 8, 2020 · 5 comments
Closed

For Cycle 10 #482

dmos62 opened this issue Feb 8, 2020 · 5 comments
Assignees
Labels
was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@dmos62
Copy link

dmos62 commented Feb 8, 2020

Summary

  • BSQ requested: 1470 (= 900 EUR @ 0.67 USD/BSQ and 0.91 USD/EUR)

Contributions delivered

Out of the PRs below, I am requesting compensation for only the first one. The first pull request below was submitted during Cycle 9, before the new compensation rules were introduced (compensated contributions must align with priorities). @ripcurlx discussed it with me and led me to believe that seeking compensation on this cycle shouldn't be a problem, rationale being that it was submitted before compensation policy was changed.

The second DAO charts PR was submitted during Cycle 10; therefore, I'm not asking for its compensation.

Changes to DAO charts:

  • #3890 Improve readability of the daily burnt BSQ chart, 1470 BSQ:
    This is the first set of changes to these charts that primarily affected the daily burnt BSQ chart, but also forced the monthly issued BSQ chart's Y-axis to include zero. Changes to the daily BSQ burnt chart helped with outlier distortion and general noisiness in the data series.

  • #3910 Add new BSQ issued v. burnt chart, 0 BSQ:
    This PR introduced a monthly chart for comparing BSQ issue against BSQ burn. According to donated use-cases in a dedicated issue thread, this was the most common use for the DAO charts.

Other:

  • #3745 Rename "Spread" tab to a more general "Details", 0 BSQ:
    This is a minute change; not asking for compensation.

Contributions in progress

  • #3273:
    Working on detecting and handling when a local bitcoin node is used and configured to prune and/or not accept bloom filter queries. Discovered how the Bitcoin protocol (and bitcoinj in turn) exposes this information. Now trying to figure out how to handle it and where to put this logic.

This is my first venture into the setup and messaging parts of Bisq. It's somewhat intimidating and relaxing at the same time, because while the system isn't small or simple, I find the codebase to be well kept and easy to read.

@ripcurlx
Copy link
Contributor

  • #3890 Improve readability of the daily burnt BSQ chart, 1470 BSQ:
    This is the first set of changes to these charts that primarily affected the daily burnt BSQ chart, but also forced the monthly issued BSQ chart's Y-axis to include zero. Changes to the daily BSQ burnt chart helped with outlier distortion and general noisiness in the data series.

I think as mentioned in our Keybase chat I think it is fine to include this PR into our cycle 10 dev budget, because of the reason mentioned above.

@dmos62
Copy link
Author

dmos62 commented Feb 11, 2020

DAO proposal transaction ID: ed4b2d982a056ff0a02d0934bf7e1ad1385e003ae1f5cb591017d40979cda70f

I'm getting a weird bug with my window manager where I couldn't copy-paste the tx id or switch windows. Something to do with my wm not handling Bisq popups properly. I had to copy the id by hand, so there might be a typo. I'll try and get my wm sorted tomorrow.

@sqrrm
Copy link
Member

sqrrm commented Feb 11, 2020

@dmos62 I suggest checking the log for the txid if you're not able to copy from client. Sounds painful to copy by hand.

@dmos62
Copy link
Author

dmos62 commented Feb 11, 2020

@dmos62 I suggest checking the log for the txid if you're not able to copy from client. Sounds painful to copy by hand.

Haha, that's smarter. Apparently, I didn't make a mistake. The ID is correct as posted above.

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Feb 22, 2020
@MwithM
Copy link
Contributor

MwithM commented Feb 22, 2020

Was accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

5 participants