Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 56 #1494

Closed
axpoems opened this issue Feb 26, 2024 · 5 comments
Closed

For Cycle 56 #1494

axpoems opened this issue Feb 26, 2024 · 5 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@axpoems
Copy link

axpoems commented Feb 26, 2024

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 10465.12
  • USD requested: 18000
  • BSQ rate: 1.72 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 55 #1470

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Bisq 2 PR:
Add missing reference to base class in BisqEasyProtocol
dev https://github.com/bisq-network/bisq2/pull/#1644
Bisq 2 PR:
Redesign BisqEasy protocol to work fully async and reduce waiting times
dev https://github.com/bisq-network/bisq2/pull/#1647 • Redesign BisqEasy protocol to work fully async in trades between peers and achieve faster/smoother trades by reducing waiting times.
• Also, this protocol now allows the takers to send their account details right after taking an offer without having to wait for a response first.
Bisq 2 PR:
Add missing header license
dev https://github.com/bisq-network/bisq2/pull/#1648
Bisq 2 PR Review:
dev https://github.com/bisq-network/bisq2/pull/#1649 ACK
Bisq 2 PR:
Pass filter as reference instead of recreating it from scratch
dev https://github.com/bisq-network/bisq2/pull/#1651 • This fixes missing out on MailboxRequests and AddAppendOnlyDataRequests. The check on missing requests needs to be performed on the inventory filter which keeps track of all the entries.
Bisq 2 PR:
Private chat improvements
dev https://github.com/bisq-network/bisq2/pull/#1652 • Add dropdown menu in private chats and move "Leave chat" inside as an option.
• Add popup to confirm leaving a chat (resolves Add pop-up to confirm leaving a channel #1638).
• Reset placeholder text in ChatMessagesListView if not in a CommonPublicChat.
• Update dropdown menu icon when hovering/active.
Bisq 2 PR:
Review and update red palette
dev https://github.com/bisq-network/bisq2/pull/#1653 • Updating the shades of red for a better experience.
Bisq 2 PR:
Implement a new design for the BisqEasy Offerbook
dev https://github.com/bisq-network/bisq2/pull/#1657 Towards issue #1572
• Implement a new design for the BisqEasy Offerbook
• Introduce logos for all the fiat markets
Bisq 2 PR:
Change icons and styles for chat scroll down solution
dev https://github.com/bisq-network/bisq2/pull/#1661 Change the icons and styles for chat scroll down solution:
• without new messages and,
• with new messages
Bisq 2 PR:
Add protocol version to TradeProtocol
dev https://github.com/bisq-network/bisq2/pull/#1662 Resolves issue #1655
• Add a new field to TradeProtocol to track versioning
• Pass protocol version into TradeMessage
Bisq 2 PR:
Improve margins to align chatbox messages in listView
dev https://github.com/bisq-network/bisq2/pull/#1664 • Improves dynamically setting the margins of chat messages.
Prior to this, the solution was aiming to account for whether the scroll bar was showing or not. However, this proved not to be reliable enough and also had to be computed on runOnNextRenderFrame which gave a bad UX (it was setting the margins after the first click).
Bisq 2 PR:
Fix margins for full width chat messages
dev https://github.com/bisq-network/bisq2/pull/#1666 • Introduce handling margins considering scrollbar for full width chat messages.
Bisq 2 PR:
Add market logos to TradeWizard
dev https://github.com/bisq-network/bisq2/pull/#1668
Bisq 2 PR:
Complete refactor of chat messages for better handling of different message types
dev https://github.com/bisq-network/bisq2/pull/#1669 • Decoupling the logic of multiple types of chat messages that can appear in the chat box so that they are well-defined and other types can be introduced easily.
Bisq 2 PR:
UI style improvements
dev https://github.com/bisq-network/bisq2/pull/#1670 Improve:
• leaveChat item menu red tone when hovering.
• Remove round corners at the bottom of the chat window.
• Remove pixel from highlight selection in private chats list selection.
Bisq 2 PR:
Introduce UI for system messages
dev https://github.com/bisq-network/bisq2/pull/#1673 Resolves issue #1639
• Introduce UI for system messages.
• Enable system messages when requesting mediation.
Bisq 2 PR:
Improve offerbook market selection subheader
dev https://github.com/bisq-network/bisq2/pull/#1677 • Add icons for the sorting dropdown menu and remove text on main button.
• Enlarge search button since now it can have more space.
• Change Offers to Most offers.
Bisq 2 PR:
Only create trade when contract has been set
dev https://github.com/bisq-network/bisq2/pull/#1678 • Update my open trades to only process the trade after the contract has been set.
Bisq 2 PR:
Add hover highlight functionality in dropdown menu for icons
dev https://github.com/bisq-network/bisq2/pull/#1679 Resolves issue #1541
• Add hover highlight functionality in dropdown menu for icons, matching the text.
• Add all the icons necessary for this (info, help and leave chat).
• Add tooltips in dropdown menu.
Bisq 2 PR:
Market logo placeholder
dev https://github.com/bisq-network/bisq2/pull/#1681 Fix market logo placeholder (markets without country flag):
• Make placeholder the same size as the logos.
• Change the text colour to be visible.
Bisq 2 PR:
Add btc-fiat pair logo to offerbook market selector header title
dev https://github.com/bisq-network/bisq2/pull/#1682 • Add icon to the offerbook market selector header title with both quote and base market logos.
• Add icons with btc logo.
• Change all chat header title colour to -bisq-white.
Bisq 2 PR:
Add dropdown menu with delete option to BisqEasy my offer message
dev https://github.com/bisq-network/bisq2/pull/#1683 Resolves issue #1680
• Refactor chat messages: add different classes for BisqEasy offer messages.
• Replace delete offer button with a dropdown menu with the delete option.
• Add popup to confirm deleting an offer.
• Introduce new delete icon.
• Introduce new shades of grey.
• Make MyMessage and PeerMessage have the same tone of grey (a darker one).
Bisq 2 PR:
Improve dropdown menu to handle multiple selection categories
dev https://github.com/bisq-network/bisq2/pull/#1684 Towards issue #1672
• Improve dropdown menu to handle multiple selection categories.
• Add filter options to the market selector dropdown menu.
• Show current criterion (for both filter and sort) in dropdown menu.
• Add check icons.
Bisq 2 PR:
Replace leave chat button with system message
dev https://github.com/bisq-network/bisq2/pull/#1686 Resolves issue #1676
• Add LeaveChatMessage type to display leave messages as system messages with hyperlink to leave chat, and remove the existing button appearing on the right of the input bar.
• Add info popup before leaving a chat.
• Add green leave-chat icon.
• Minor code refactors.
Bisq 2 PR:
Improve implementation to dynamically set paddings to chat messages
dev https://github.com/bisq-network/bisq2/pull/#1687 • Fixes paddings not being set correctly for the case of no scrollbar with max width applied.
• Fixes occasional flickering of chat messages.
• Fixes small misalignment with header and input bar.
Bisq 2 PR:
Fix chat message rendering issue when updating styles
dev https://github.com/bisq-network/bisq2/pull/#1688 • Remove the listener from cell and delegate setting max chat box width to the message class so that the latter can be used to keep track of changes and update accordingly.
Bisq 2 PR:
Add new info and help icons to drop-menus
dev https://github.com/bisq-network/bisq2/pull/#1689 Towards issue #1211
• Add new, clean redesigned info and help icons for chats drop-menus.
Bisq 2 PR:
Update navigation icons to match bisq2 green colour
dev https://github.com/bisq-network/bisq2/pull/#1690 Towards issue #1211
• Update the main navigation icons to match bisq2 green colour.
Bisq 2 PR:
Fix regression in dropdown menu item
dev https://github.com/bisq-network/bisq2/pull/#1692 • Fix regression in dropdown menu items, which were not filling up the entire available space.
dev 18000 Total

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Feb 26, 2024
@MwithM MwithM added this to the Cycle 56 milestone Feb 27, 2024
@ripcurlx
Copy link
Contributor

@HenrikJannsen: Could you please ACK this CR? Thanks!

@axpoems
Copy link
Author

axpoems commented Feb 27, 2024

b9b36165a4837e740bb9cdac981d14b8f792cac36642b39a86d07bd30e6139d9

@HenrikJannsen
Copy link

ACK

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Mar 9, 2024
@ghost
Copy link

ghost commented Mar 9, 2024

Issuance by Team:

team amount BSQ amount USD
dev 10465.12 18000.00

Total Issuance: 10465.12 BSQ (equivalent to: 18000.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Mar 9, 2024

Closed as accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

4 participants