Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find better solution for create offer button and user profile selection at input field #1572

Closed
HenrikJannsen opened this issue Jan 6, 2024 · 4 comments
Assignees
Labels
Milestone

Comments

@HenrikJannsen
Copy link
Contributor

When a user has multiple profiles we show the profile selection next to the create offer button at the input box (only at public chats).
We should find a better solution for that situation.

@axpoems Any idea?

@axpoems
Copy link
Contributor

axpoems commented Jan 6, 2024

Yes, I'm already working on this. I'll be relocating the 'Create Offer' button to another place. I'll be uploading the mock-up for the Offerbook very soon.

@HenrikJannsen HenrikJannsen added this to the 2.0.0 milestone Jan 6, 2024
@axpoems
Copy link
Contributor

axpoems commented Jan 10, 2024


This is the mock-up of the review and solution proposed for the Offerbook.


offerbook2


With the drop-down menus options.

offerbook2_dp-menu


@HenrikJannsen Looking forward to hear your thoughts about it.

@HenrikJannsen
Copy link
Contributor Author

HenrikJannsen commented Jan 11, 2024

Looks good!

I assume the star is a favorite feature. How to add an item as favorite?

My only concern is that in minimal width size the new left market navigation takes some space.
But we could maybe only show that when width is > xxx px and otherwise use the dropdown similar as it is now.
I also expect that there will not be too many markets filled with offers, at least in the bootstrap phase. Then the navigation looks a bit bad as its visible that only maybe 4-6 markets have offers at all. Hope I am wrong on that ;-).

But like the layout and the filter options.
The Higher/Lower offers is probably the number or offers. Not sure if the sorting by low offers is much useful. Maybe we could use "Most offers" and "Most messages" instead?

Not sure if it would be better to show also the fiat next to the BTC icon at the selected market. Designwise it looks nice as it is, so not sure if both icons would fit that well.

The new send icon looks a bit too sharp to me. Maybe a paper-plane like send button would be better?

@axpoems
Copy link
Contributor

axpoems commented Jan 11, 2024

I assume the star is a favorite feature. How to add an item as favorite?

I have some ideas on how to do that. I am thinking about implementing this as an independent feature. I will create a separate issue for this.

My only concern is that in minimal width size the new left market navigation takes some space.
But we could maybe only show that when width is > xxx px and otherwise use the dropdown similar as it is now.

I don't see the necessity for this. This is the same as the private chats layout and I have tested it and it looks good on smaller screens.

I also expect that there will not be too many markets filled with offers, at least in the bootstrap phase. Then the navigation looks a bit bad as its visible that only maybe 4-6 markets have offers at all. Hope I am wrong on that ;-).

Well at the bootstrap phase everyone should understand is empty. It could also serve as an invitation to someone make some offers in that market.

But like the layout and the filter options.
The Higher/Lower offers is probably the number or offers. Not sure if the sorting by low offers is much useful. Maybe we could use "Most offers" and "Most messages" instead?

Yes, I like those suggestions as well.

Not sure if it would be better to show also the fiat next to the BTC icon at the selected market. Designwise it looks nice as it is, so not sure if both icons would fit that well.

I have tried that out, but it looks somewhat redundant since the flag is already below. Anyway I will play a little bit more with this when implementing it and see if there's a better option.

The new send icon looks a bit too sharp to me. Maybe a paper-plane like send button would be better?

This is just for the mock-up, although it is was taken from a screenshot of the current icon.
We can update the icon as you mention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants