Clone transaction before committing to wallet #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK |
|
@rachmaninovquartet Thanks for the review. Could you elaborate on any potential risks you see with this PR? Do you think it should also be merge to the main bitcoinj repo? |
|
I'm closing this PR and cherry picking the commit that was merged upstream. |
|
Replaced by #38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically the same PR as #21 but it's now a real issue. This PR also clones
purposewhich wasn't done in the earlier PR.Atomic transactions that have inputs and outputs relating to two wallets are received from the network and added through
receivePending(). To avoid adding the same instance of a transaction to two wallets a clone is made and added instead. These transactions come from the network so they don't yet have any wallet data associated with them.