Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electrum: Remove setters in RPC response classes #529

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,9 @@

import bisq.wallets.json_rpc.JsonRpcResponse;
import lombok.Getter;
import lombok.Setter;

public class ElectrumCreateResponse extends JsonRpcResponse<ElectrumCreateResponse.Result> {
@Getter
@Setter
public static class Result {
private String msg;
private String path;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,8 @@

import com.squareup.moshi.Json;
import lombok.Getter;
import lombok.Setter;

@Getter
@Setter
public class ElectrumDeserializeInputResponse {
private boolean coinbase;
@Json(name = "nsequence")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,8 @@

import com.squareup.moshi.Json;
import lombok.Getter;
import lombok.Setter;

@Getter
@Setter
public class ElectrumDeserializeOutputResponse {
private String address;
@Json(name = "scriptpubkey")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,8 @@

import com.squareup.moshi.Json;
import lombok.Getter;
import lombok.Setter;

@Getter
@Setter
public class ElectrumDeserializeOutputResponseInput {
@Json(name = "prevout_hash")
private String prevOutHash;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,12 @@
import bisq.wallets.json_rpc.JsonRpcResponse;
import com.squareup.moshi.Json;
import lombok.Getter;
import lombok.Setter;

import java.util.List;

@Getter
@Setter
public class ElectrumDeserializeResponse extends JsonRpcResponse<ElectrumDeserializeResponse.Result> {
@Getter
@Setter
public static class Result {
private List<ElectrumDeserializeInputResponse> inputs;
@Json(name = "locktime")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,10 @@

import bisq.wallets.json_rpc.JsonRpcResponse;
import lombok.Getter;
import lombok.Setter;

@Getter
@Setter
public class ElectrumGetBalanceResponse extends JsonRpcResponse<ElectrumGetBalanceResponse.Result> {
@Getter
@Setter
public static class Result {
private String confirmed;
private String unconfirmed;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,10 @@
import bisq.wallets.json_rpc.JsonRpcResponse;
import com.squareup.moshi.Json;
import lombok.Getter;
import lombok.Setter;

@Getter
@Setter
public class ElectrumGetInfoResponse extends JsonRpcResponse<ElectrumGetInfoResponse.Result> {
@Getter
@Setter
public static class Result {
@Json(name = "auto_connect")
private boolean isAutoConnectEnabled;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,13 @@
import bisq.wallets.json_rpc.JsonRpcResponse;
import com.squareup.moshi.Json;
import lombok.Getter;
import lombok.Setter;

import java.util.List;
import java.util.Map;

@Getter
@Setter
public class ElectrumListUnspentResponse extends JsonRpcResponse<List<ElectrumListUnspentResponse.Result>> {
@Getter
@Setter
public static class Result implements Utxo {
private String address;
@Json(name = "bip32_paths")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,8 @@

import com.squareup.moshi.Json;
import lombok.Getter;
import lombok.Setter;

@Getter
@Setter
public class ElectrumOnChainHistoryBeginEndResponse {
@Json(name = "BTC_balance")
private String btcBalance;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,8 @@

import com.squareup.moshi.Json;
import lombok.Getter;
import lombok.Setter;

@Getter
@Setter
public class ElectrumOnChainHistoryFlowResponse {
@Json(name = "BTC_incoming")
private String btcIncoming;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,12 @@

import bisq.wallets.json_rpc.JsonRpcResponse;
import lombok.Getter;
import lombok.Setter;

import java.util.List;

@Getter
@Setter
public class ElectrumOnChainHistoryResponse extends JsonRpcResponse<ElectrumOnChainHistoryResponse.Result> {
@Getter
@Setter
public static class Result {
private ElectrumOnChainHistorySummaryResponse summary;
private List<ElectrumOnChainTransactionResponse> transactions;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,8 @@
package bisq.wallets.electrum.rpc.responses;

import lombok.Getter;
import lombok.Setter;

@Getter
@Setter
public class ElectrumOnChainHistorySummaryResponse {
private ElectrumOnChainHistoryBeginEndResponse begin;
private ElectrumOnChainHistoryBeginEndResponse end;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,8 @@
import bisq.wallets.core.model.Transaction;
import com.squareup.moshi.Json;
import lombok.Getter;
import lombok.Setter;

@Getter
@Setter
public class ElectrumOnChainTransactionResponse implements Transaction {
@Json(name = "bc_balance")
private String bcBalance;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,10 @@

import bisq.wallets.json_rpc.JsonRpcResponse;
import lombok.Getter;
import lombok.Setter;

@Getter
@Setter
public class ElectrumPasswordResponse extends JsonRpcResponse<ElectrumPasswordResponse.Result> {
@Getter
@Setter
public static class Result {
private boolean password;
}
Expand Down