Tor: Ship all required shared libraries with Bisq #2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tor failed to start for some users because their operating system didn't ship Tor's dependencies. This change instructs the package manager to install tor and all its required during the Bisq installation. Fixes bisq-network#2906
During Bisq's installation the OS's package manager automatically installs Tor and its required dependecies.
During Bisq's installation the OS's package manager automatically installs Tor and its required dependecies.
alvasw
added a commit
to alvasw/bisq2
that referenced
this pull request
Oct 21, 2024
PR bisq-network#2938 unbundles Tor from Bisq on Linux and switches to the OSes Tor binary. If a user updates from a prior version their data directory will contain the old extracted Tor binaries. The migration in this change removes the obsolete files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tor failed to start for some users because their operating system didn't ship Tor's dependencies. This change instructs the package manager to install tor and all its required during the Bisq installation. Furthermore, we don't need to ship the Tor binary and its libraries on Linux anymore leading to package size savings.
Changes:
Fixes #2906