Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial version of building binary #218

Merged
merged 2 commits into from
Apr 9, 2022
Merged

Add initial version of building binary #218

merged 2 commits into from
Apr 9, 2022

Conversation

alkum
Copy link
Contributor

@alkum alkum commented Apr 8, 2022

Add shadow jar and jpackager plugins that allow the building of platform-specific binaries and installers.

Add shadow jar and jpackager plugins that allow the building of platform-specific binaries and installers.
@alkum alkum marked this pull request as draft April 8, 2022 21:29
@chimp1984
Copy link
Contributor

Tested it on OSX and worked like a charm!

Ensure the project works with a clean build directory.
@alkum alkum marked this pull request as ready for review April 9, 2022 09:31
@alkum
Copy link
Contributor Author

alkum commented Apr 9, 2022

Added some minor improvements.

Tested on Linux, Mac and Windows.

Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@chimp1984 chimp1984 merged commit ac0d3b1 into bisq-network:main Apr 9, 2022
@alkum alkum deleted the jpackager branch April 9, 2022 11:11
@alkum alkum mentioned this pull request Apr 9, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants