Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump gradle wrapper to 7.4.1 + centralize lib version mgmt #176

Merged
merged 3 commits into from
Mar 30, 2022
Merged

Bump gradle wrapper to 7.4.1 + centralize lib version mgmt #176

merged 3 commits into from
Mar 30, 2022

Conversation

alkum
Copy link
Contributor

@alkum alkum commented Mar 29, 2022

Update the gradle wrapper using

./gradlew wrapper --gradle-version 7.4.1 --distribution-type bin

@alkum
Bump gradle wrapper to 7.4.1
678cfd9 
Update the gradle wrapper.
@alkum alkum mentioned this pull request Mar 29, 2022
Closed
@alkum
Consolidate version management
4d53f93 
Define versions in libs.versions.toml.
@alkum alkum changed the title Bump gradle wrapper to 7.4.1 Bump gradle wrapper to 7.4.1 + centralize lib version mgmt Mar 29, 2022
chimp1984
chimp1984 reviewed Mar 29, 2022
View reviewed changes
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See open questions regarding distributionSha256Sum

@alkum
Copy link
Contributor Author

alkum commented Mar 30, 2022

See open questions regarding distributionSha256Sum

Fixed. Sorry was my bad, late at night and didnt realise the checksum was missing.

@alkum
Copy link
Contributor Author

alkum commented Mar 30, 2022

Related to #178

chimp1984
chimp1984 approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@chimp1984 chimp1984 merged commit ef11787 into bisq-network:main Mar 30, 2022
@alkum alkum deleted the update-gradle-add-versions branch March 30, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chimp1984 chimp1984 chimp1984 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alkum @chimp1984