Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add display hint for applied market filers #1751

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Add display hint for applied market filers #1751

merged 4 commits into from
Mar 11, 2024

Conversation

axpoems
Copy link
Contributor

@axpoems axpoems commented Mar 7, 2024 •
edited
Loading

image

HenrikJannsen
HenrikJannsen approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@namloan
Copy link
Contributor

namloan commented Mar 8, 2024

utACK

Thanks a lot!

alvasw
alvasw approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alvasw
Copy link
Contributor

alvasw commented Mar 8, 2024

This PR has conflicts that must be resolved.

Conflicting files:
apps/desktop/desktop/src/main/java/bisq/desktop/main/content/components/chatMessages/messages/MyMessage.java

@axpoems axpoems force-pushed the improvements-market-selector branch from 0590ca1 to 86e5f2d Compare March 8, 2024 18:00
@axpoems
Copy link
Contributor Author

axpoems commented Mar 8, 2024

@alvasw Fixed now.

alvasw
alvasw approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alvasw alvasw merged commit 5edacfa into bisq-network:main Mar 11, 2024
16 checks passed
@axpoems axpoems mentioned this pull request Mar 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvasw alvasw alvasw approved these changes

@HenrikJannsen HenrikJannsen HenrikJannsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display a hint about filters being applied to offerbook channel list
4 participants
@axpoems @namloan @alvasw @HenrikJannsen