Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend PeerExchangeService with optimistic peer exchange #171

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Extend PeerExchangeService with optimistic peer exchange #171

merged 2 commits into from
Mar 29, 2022

Conversation

alkum
Copy link
Contributor

@alkum alkum commented Mar 28, 2022

Extend the peer exchange logic with ability to complete future when first peer exchange succeeds (optimistic scenario). Alternatively, wait until all peer connections have been tried.

alkum added 2 commits March 28, 2022 22:13
@alkum
Extend CompletableFutureUtils with boolean future utils and add tests
36cfb13 
Include util for boolean futures which has two completion conditions.
@alkum
Extend PeerExchangeService with optimistic peer exchange
1ff0cae 
Extend the peer exchange logic with ability to complete future when first peer exchange succeeds (optimistic scenario). Alternatively, wait until all peer connections have been tried.
@alkum alkum marked this pull request as draft March 28, 2022 20:21
@alkum alkum mentioned this pull request Mar 28, 2022
Closed
@alkum alkum marked this pull request as ready for review March 29, 2022 12:54
chimp1984
chimp1984 reviewed Mar 29, 2022
View reviewed changes
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyOfBooleanMatchingFilterOrAll is not very intuitive, but I think I also dont have a better suggestion.
Not sure if its a too specific case to use as Util. But fine to me to keep it as it is for now.

chimp1984
chimp1984 approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@chimp1984 chimp1984 merged commit 385aaea into bisq-network:main Mar 29, 2022
@alkum alkum deleted the i2p-fix-client-needs-2-seeds-online branch March 29, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chimp1984 chimp1984 chimp1984 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alkum @chimp1984