Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store seeds in Sets to avoid duplicates #169

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Store seeds in Sets to avoid duplicates #169

merged 1 commit into from
Mar 29, 2022

Conversation

alkum
Copy link
Contributor

@alkum alkum commented Mar 28, 2022

In some tests, there were multiple connections to the same seed. Eliminate duplicates by storing and passing seeds in hashsets.

@alkum alkum marked this pull request as draft March 28, 2022 14:44
@alkum alkum mentioned this pull request Mar 28, 2022
Closed
@alkum
Store seeds in Sets to avoid duplicates
d7e502d 
In some tests, there were multiple connections to the same seed. Eliminate duplicates by storing and passing seeds in hashsets.
@alkum alkum marked this pull request as ready for review March 29, 2022 19:54
chimp1984
chimp1984 approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@chimp1984 chimp1984 merged commit bb6449d into bisq-network:main Mar 29, 2022
@alkum alkum deleted the store-seeds-in-sets branch March 30, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chimp1984 chimp1984 chimp1984 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alkum @chimp1984