Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Optional instead of Nullable in Account module #1631

Closed
djing-chan opened this issue Jan 23, 2024 · 1 comment
Closed

Use Optional instead of Nullable in Account module #1631

djing-chan opened this issue Jan 23, 2024 · 1 comment
Assignees
@bsc7
Labels
good first issue Good for newcomers refactoring

Comments

@djing-chan
Copy link
Contributor

See TODOs "use Optional instead of Nullable"
@HenrikJannsen HenrikJannsen added the good first issue Good for newcomers label Jan 24, 2024
@dirka1992 dirka1992 mentioned this issue Mar 9, 2024
Closed
@bsc7
Copy link
Contributor

bsc7 commented Oct 20, 2024

would like to finish that

bsc7 added a commit to bsc7/bisq2 that referenced this issue Oct 21, 2024
@bsc7
Refact: m/account: Nullable -> Optional bisq-network#1631
2b232d1
bsc7 added a commit to bsc7/bisq2 that referenced this issue Oct 21, 2024
@bsc7
Refact: m/account: Nullable -> Optional bisq-network#1631
7a74a6a
bsc7 added a commit to bsc7/bisq2 that referenced this issue Oct 22, 2024
@bsc7
Refact: m/account: Nullable -> Optional bisq-network#1631
190dcaa 
see also bisq-network#1106
HenrikJannsen added a commit that referenced this issue Oct 23, 2024
@HenrikJannsen
Merge pull request #2947 from bsc7/feature/1631/replace-nullable-with…
7e782fe 
…-optional

Refact: m/account: Nullable -> Optional #1631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsc7 bsc7

Labels
good first issue Good for newcomers refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace nullable with optional dirka1992/bisq2
3 participants
@HenrikJannsen @bsc7 @djing-chan