Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception due to missing read lock. #6588

Merged
merged 1 commit into from Feb 15, 2023
Merged

Fix exception due to missing read lock. #6588

merged 1 commit into from Feb 15, 2023

Conversation

ghost
Copy link

@ghost ghost commented Feb 15, 2023

Related to #6551

Fixes the following exception at startup:

Feb-15 16:00:10.554 [SeedNodeMain] ERROR b.c.s.CommonSetup: Uncaught Exception from thread SeedNodeMain 
Feb-15 16:00:10.554 [SeedNodeMain] ERROR b.c.s.CommonSetup: throwableMessage= attempt to unlock read lock, not locked by current thread 
Feb-15 16:00:10.554 [SeedNodeMain] ERROR b.c.s.CommonSetup: throwableClass= class java.lang.IllegalMonitorStateException 
Feb-15 16:00:10.602 [SeedNodeMain] ERROR b.c.s.CommonSetup: Stack trace:
java.lang.IllegalMonitorStateException: attempt to unlock read lock, not locked by current thread
    at java.base/java.util.concurrent.locks.ReentrantReadWriteLock$Sync.unmatchedUnlockException(ReentrantReadWriteLock.java:448)
    at java.base/java.util.concurrent.locks.ReentrantReadWriteLock$Sync.tryReleaseShared(ReentrantReadWriteLock.java:432)
    at java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer.releaseShared(AbstractQueuedSynchronizer.java:1382)
    at java.base/java.util.concurrent.locks.ReentrantReadWriteLock$ReadLock.unlock(ReentrantReadWriteLock.java:897)
    at bisq.core.dao.burningman.accounting.storage.BurningManAccountingStore.getBlockAtHeight(BurningManAccountingStore.java:102)
    at bisq.core.dao.burningman.accounting.storage.BurningManAccountingStoreService.getBlockAtHeight(BurningManAccountingStoreService.java:85)
    at bisq.core.dao.burningman.accounting.BurningManAccountingService.getBlockAtHeight(BurningManAccountingService.java:148)
    at bisq.core.dao.burningman.accounting.node.full.AccountingFullNode.parseBlock(AccountingFullNode.java:244)
    at bisq.core.dao.burningman.accounting.node.full.AccountingFullNode.lambda$requestBlockRecursively$8(AccountingFullNode.java:226)
    at bisq.core.dao.node.full.RpcService$4.lambda$onSuccess$0(RpcService.java:385)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
    at java.base/java.lang.Thread.run(Thread.java:834)

Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit 9d091be into bisq-network:master Feb 15, 2023
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.10 milestone Feb 15, 2023
@ghost ghost mentioned this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants