-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBAN validation for SEPA account #6107
Conversation
Reviewed, could confirm all changes except the last one:
That error is indeed shown, but ignored. A SEPA account can still be created, despite this error being shown. (With the other error, Tested using sample IBANs from https://www.iban.com/structure |
@alkum Thanks - please check now. Also please wait with merge - I'll adapt Sepa Instant Form once everything will be okay on standard Sepa |
Checked again, validation works for standard SEPA accounts. |
@@ -120,14 +127,34 @@ public void addFormForAddAccount() { | |||
sepaAccount.setCountry(country); | |||
} | |||
|
|||
ibanInputTextField.textProperty().addListener((ov, oldValue, newValue) -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why you introduce another listener to the textProperty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not actually - I merged those listeners into one.
Listener is not added directly after ibanInputTextField
declaration because it needs countryComboBox
desktop/src/main/java/bisq/desktop/components/paymentmethods/SepaInstantForm.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK - Remaining code changes are looking fine. utACK also based on #6107 (comment)
Fixes bisq-network/growth#241
Superseds #5419
Changes:
SEPA is not supported in this country
Country code invalid
below IBAN field