-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to keybase and switch to Matrix #6005
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good initiative! A couple of comments:
- you should only commit changes to the main
displayStrings.properties
; the translated ones are updated automatically by transifex - pazza in class
DisputeAgentLookupMap
should be changed to pazza83
thanks for the comments! |
ok I missed that you already got that pazza83 name change. 👍 |
Ouch, I do hope he doesn't ask me to adjust it, because I definitely can, but then I couldn't for the life of me squash the commits together even if he was so incredibly kind to show me in my previous PR |
|
Saving this nice writeup for later use! Nice little abstract, thanks! |
20963a7
to
f9dc2ee
Compare
I think I've done it @jmacxx ! Had to mess with the access token thingamajig but it appears to have worked! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK - Code changes are looking fine 👍
@w0000000t But your account is not properly signed 😅 |
...I know what happened. |
Except `dao.bond.bondedRoleType.ROCKET_CHAT_ADMIN` which refers to an unused role, every other instance of `keybase` has been contextually updated to Matrix (bisq.chat); functions to display moderator name and profile address on keybase have been updated to work with Matrix usernames and urls. Kept translated resources in original state as per jmacxx suggestion.
0d7da88
to
7b191a4
Compare
@ripcurlx please confirm I didn't make a complete mess, it appears signed now and I should have squashed all commits now, maybe? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK - Changes are looking fine 👍
Except
dao.bond.bondedRoleType.ROCKET_CHAT_ADMIN
which refers to anunused role, every other instance of
keybase
has been contextuallyupdated to Matrix (bisq.chat); functions to display moderator name
and profile address on keybase have been updated to work with Matrix
usernames and urls.
Fixes #replaceWithIssueNr, fixes #replaceWithIssueNr
Your PR description here.