Add API 'gettrades' method

apitest/src/test/java/bisq/apitest/method/offer/AbstractOfferTest.java

@@ -17,12 +17,15 @@
 
 package bisq.apitest.method.offer;
 
+import bisq.core.offer.OfferDirection;
+
 import bisq.proto.grpc.OfferInfo;
 
 import protobuf.PaymentAccount;
 
 import java.math.BigDecimal;
 
+import java.util.ArrayList;
 import java.util.List;
 import java.util.function.BiFunction;
 import java.util.function.Function;
@@ -42,12 +45,16 @@
 import static bisq.apitest.config.BisqAppConfig.seednode;
 import static bisq.cli.table.builder.TableType.OFFER_TBL;
 import static bisq.common.util.MathUtils.exactMultiply;
+import static java.lang.String.format;
 import static java.lang.System.out;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.fail;
 
 
 
 import bisq.apitest.method.MethodTest;
 import bisq.cli.CliMain;
+import bisq.cli.GrpcClient;
 import bisq.cli.table.builder.TableBuilder;
 
 @Slf4j
@@ -122,6 +129,34 @@ public static void setUp() {
     protected final Function<List<OfferInfo>, String> toOffersTable = (offers) ->
             new TableBuilder(OFFER_TBL, offers).build().toString();
 
+    protected OfferInfo getAvailableBsqSwapOffer(GrpcClient client,
+                                                 OfferDirection direction,
+                                                 boolean checkForLoggedExceptions) {
+        List<OfferInfo> bsqSwapOffers = new ArrayList<>();
+        int numFetchAttempts = 0;
+        while (bsqSwapOffers.size() == 0) {
+            bsqSwapOffers.addAll(client.getBsqSwapOffers(direction.name()));
+            numFetchAttempts++;
+            if (bsqSwapOffers.size() == 0) {
+                log.warn("No available bsq swap offers found after {} fetch attempts.", numFetchAttempts);
+                if (numFetchAttempts > 9) {
+                    if (checkForLoggedExceptions) {
+                        printNodeExceptionMessages(log);
+                    }
+                    fail(format("Bob gave up on fetching available bsq swap offers after %d attempts.", numFetchAttempts));
+                }
+                sleep(1_000);
+            } else {
+                assertEquals(1, bsqSwapOffers.size());
+                log.debug("Bob found new available bsq swap offer on attempt # {}.", numFetchAttempts);
+                break;
+            }
+        }
+        var bsqSwapOffer = bobClient.getBsqSwapOffer(bsqSwapOffers.get(0).getId());
+        assertEquals(bsqSwapOffers.get(0).getId(), bsqSwapOffer.getId());
+        return bsqSwapOffer;
+    }
+
     @SuppressWarnings("ConstantConditions")
     public static void initSwapPaymentAccounts() {
         // A bot may not know what the default 'BSQ Swap' account name is,

apitest/src/test/java/bisq/apitest/method/trade/AbstractTradeTest.java

@@ -264,4 +264,18 @@ protected static void runCliGetTrade(String tradeId) {
         out.println("Bob's CLI 'gettrade' response:");
         CliMain.main(new String[]{"--password=xyz", "--port=9999", "gettrade", "--trade-id=" + tradeId});
     }
+
+    protected static void runCliGetOpenTrades() {
+        out.println("Alice's CLI 'gettrades --category=open' response:");
+        CliMain.main(new String[]{"--password=xyz", "--port=9998", "gettrades", "--category=open"});
+        out.println("Bob's CLI 'gettrades --category=open' response:");
+        CliMain.main(new String[]{"--password=xyz", "--port=9999", "gettrades", "--category=open"});
+    }
+
+    protected static void runCliGetClosedTrades() {
+        out.println("Alice's CLI 'gettrades --category=closed' response:");
+        CliMain.main(new String[]{"--password=xyz", "--port=9998", "gettrades", "--category=closed"});
+        out.println("Bob's CLI 'gettrades --category=closed' response:");
+        CliMain.main(new String[]{"--password=xyz", "--port=9999", "gettrades", "--category=closed"});
+    }
 }

apitest/src/test/java/bisq/apitest/method/trade/BsqSwapTradeTest.java → apitest/src/test/java/bisq/apitest/method/trade/BsqSwapBuyBtcTradeTest.java

@@ -17,11 +17,9 @@
 
 package bisq.apitest.method.trade;
 
-import bisq.proto.grpc.OfferInfo;
 import bisq.proto.grpc.TradeInfo;
 
-import java.util.ArrayList;
-import java.util.List;
+import protobuf.OfferDirection;
 
 import lombok.Setter;
 import lombok.extern.slf4j.Slf4j;
@@ -36,6 +34,7 @@
 
 import static bisq.apitest.config.ApiTestConfig.BSQ;
 import static bisq.apitest.config.ApiTestConfig.BTC;
+import static bisq.core.offer.OfferDirection.BUY;
 import static bisq.proto.grpc.GetOfferCategoryReply.OfferCategory.BSQ_SWAP;
 import static java.lang.String.format;
 import static org.junit.jupiter.api.Assertions.assertEquals;
@@ -44,7 +43,6 @@
 import static org.junit.jupiter.api.Assertions.fail;
 import static protobuf.BsqSwapTrade.State.COMPLETED;
 import static protobuf.BsqSwapTrade.State.PREPARATION;
-import static protobuf.OfferDirection.BUY;
 
 
 
@@ -54,7 +52,7 @@
 @Disabled
 @Slf4j
 @TestMethodOrder(MethodOrderer.OrderAnnotation.class)
-public class BsqSwapTradeTest extends AbstractTradeTest {
+public class BsqSwapBuyBtcTradeTest extends AbstractTradeTest {
 
     // Long-running swap trade tests might want to check node logs for exceptions.
     @Setter
@@ -81,15 +79,16 @@ public void testGetBalancesBeforeTrade() {
 
     @Test
     @Order(2)
-    public void testAliceCreateBsqSwapBuyOffer() {
-        var mySwapOffer = aliceClient.createBsqSwapOffer(BUY.name(),
+    public void testAliceCreateBsqSwapBuyBtcOffer() {
+        // Alice buys BTC, pays trade fee.  Bob (BTC seller) pays miner tx fee.
+        var mySwapOffer = aliceClient.createBsqSwapOffer(OfferDirection.BUY.name(),
                 1_000_000L,     // 0.01 BTC
                 1_000_000L,
                 "0.00005");
         log.debug("Pending BsqSwap Sell BSQ (Buy BTC) OFFER:\n{}", toOfferTable.apply(mySwapOffer));
         var newOfferId = mySwapOffer.getId();
         assertNotEquals("", newOfferId);
-        assertEquals(BUY.name(), mySwapOffer.getDirection());
+        assertEquals(OfferDirection.BUY.name(), mySwapOffer.getDirection());
         assertEquals(5_000, mySwapOffer.getPrice());
         assertEquals(1_000_000L, mySwapOffer.getAmount());
         assertEquals(1_000_000L, mySwapOffer.getMinAmount());
@@ -108,7 +107,7 @@ public void testAliceCreateBsqSwapBuyOffer() {
     @Test
     @Order(3)
     public void testBobTakesBsqSwapOffer() {
-        var availableSwapOffer = getAvailableBsqSwapOffer(bobClient);
+        var availableSwapOffer = getAvailableBsqSwapOffer(bobClient, BUY, true);
 
         // Before sending a TakeOfferRequest, the CLI needs to know what kind of Offer
         // it is taking (v1 or BsqSwap).  Only BSQ swap offers can be taken with a
@@ -118,7 +117,7 @@ public void testBobTakesBsqSwapOffer() {
         var availableOfferCategory = bobClient.getAvailableOfferCategory(availableSwapOffer.getId());
         assertTrue(availableOfferCategory.equals(BSQ_SWAP));
 
-        sleep(30_000);
+        sleep(3_000);
 
         var swapTrade = bobClient.takeBsqSwapOffer(availableSwapOffer.getId());
         tradeId = swapTrade.getTradeId(); // Cache the tradeId for following test case(s).
@@ -130,7 +129,7 @@ public void testBobTakesBsqSwapOffer() {
         log.debug("BsqSwap Trade at COMPLETION:\n{}", toTradeDetailTable.apply(swapTrade));
         assertEquals(COMPLETED.name(), swapTrade.getState());
 
-        runCliGetTrade(tradeId);
+        runCliGetClosedTrades();
     }
 
     @Test
@@ -151,6 +150,8 @@ public void testCompletedSwapTxConfirmations() {
         bobsTrade = getBsqSwapTrade(bobClient, tradeId);
         log.debug("Bob's BsqSwap Trade at COMPLETION:\n{}", toTradeDetailTable.apply(bobsTrade));
         assertEquals(2, bobsTrade.getBsqSwapTradeInfo().getNumConfirmations());
+
+        runCliGetClosedTrades();
     }
 
     @Test
@@ -162,32 +163,6 @@ public void testGetBalancesAfterTrade() {
         log.debug("Bob's After Trade Balance:\n{}", formatBalancesTbls(bobsBalances));
     }
 
-    private OfferInfo getAvailableBsqSwapOffer(GrpcClient client) {
-        List<OfferInfo> bsqSwapOffers = new ArrayList<>();
-        int numFetchAttempts = 0;
-        while (bsqSwapOffers.size() == 0) {
-            bsqSwapOffers.addAll(client.getBsqSwapOffers(BUY.name()));
-            numFetchAttempts++;
-            if (bsqSwapOffers.size() == 0) {
-                log.warn("No available bsq swap offers found after {} fetch attempts.", numFetchAttempts);
-                if (numFetchAttempts > 9) {
-                    if (checkForLoggedExceptions) {
-                        printNodeExceptionMessages(log);
-                    }
-                    fail(format("Bob gave up on fetching available bsq swap offers after %d attempts.", numFetchAttempts));
-                }
-                sleep(1_000);
-            } else {
-                assertEquals(1, bsqSwapOffers.size());
-                log.debug("Bob found new available bsq swap offer on attempt # {}.", numFetchAttempts);
-                break;
-            }
-        }
-        var bsqSwapOffer = bobClient.getBsqSwapOffer(bsqSwapOffers.get(0).getId());
-        assertEquals(bsqSwapOffers.get(0).getId(), bsqSwapOffer.getId());
-        return bsqSwapOffer;
-    }
-
     private TradeInfo getBsqSwapTrade(GrpcClient client, String tradeId) {
         int numFetchAttempts = 0;
         while (true) {

apitest/src/test/java/bisq/apitest/method/trade/BsqSwapSellBtcTradeTest.java

@@ -0,0 +1,183 @@
+/*
+ * This file is part of Bisq.
+ *
+ * Bisq is free software: you can redistribute it and/or modify it
+ * under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or (at
+ * your option) any later version.
+ *
+ * Bisq is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package bisq.apitest.method.trade;
+
+import bisq.proto.grpc.TradeInfo;
+
+import lombok.Setter;
+import lombok.extern.slf4j.Slf4j;
+
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.MethodOrderer;
+import org.junit.jupiter.api.Order;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.TestMethodOrder;
+
+import static bisq.apitest.config.ApiTestConfig.BSQ;
+import static bisq.apitest.config.ApiTestConfig.BTC;
+import static bisq.core.offer.OfferDirection.SELL;
+import static bisq.proto.grpc.GetOfferCategoryReply.OfferCategory.BSQ_SWAP;
+import static java.lang.String.format;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.fail;
+import static protobuf.BsqSwapTrade.State.COMPLETED;
+import static protobuf.BsqSwapTrade.State.PREPARATION;
+
+
+
+import bisq.apitest.method.offer.AbstractOfferTest;
+import bisq.cli.GrpcClient;
+
+@Disabled
+@Slf4j
+@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
+public class BsqSwapSellBtcTradeTest extends AbstractTradeTest {
+
+    // Long-running swap trade tests might want to check node logs for exceptions.
+    @Setter
+    private boolean checkForLoggedExceptions;
+
+    @BeforeAll
+    public static void setUp() {
+        AbstractOfferTest.setUp();
+    }
+
+    @BeforeEach
+    public void generateBtcBlock() {
+        genBtcBlocksThenWait(1, 2_000);
+    }
+
+    @Test
+    @Order(1)
+    public void testGetBalancesBeforeTrade() {
+        var alicesBalances = aliceClient.getBalances();
+        log.debug("Alice's Before Trade Balance:\n{}", formatBalancesTbls(alicesBalances));
+        var bobsBalances = bobClient.getBalances();
+        log.debug("Bob's Before Trade Balance:\n{}", formatBalancesTbls(bobsBalances));
+    }
+
+    @Test
+    @Order(2)
+    public void testAliceCreateBsqSwapSellBtcOffer() {
+        // Alice sells BTC, pays miner tx fee.  Bob (BTC buyer) pays trade fee.
+        var mySwapOffer = aliceClient.createBsqSwapOffer(SELL.name(),
+                1_000_000L,     // 0.01 BTC
+                1_000_000L,
+                "0.00005");
+        log.debug("Pending BsqSwap Buy BSQ (Sell BTC) OFFER:\n{}", toOfferTable.apply(mySwapOffer));
+        var newOfferId = mySwapOffer.getId();
+        assertNotEquals("", newOfferId);
+        assertEquals(SELL.name(), mySwapOffer.getDirection());
+        assertEquals(5_000, mySwapOffer.getPrice());
+        assertEquals(1_000_000L, mySwapOffer.getAmount());
+        assertEquals(1_000_000L, mySwapOffer.getMinAmount());
+        assertEquals(BSQ, mySwapOffer.getBaseCurrencyCode());
+        assertEquals(BTC, mySwapOffer.getCounterCurrencyCode());
+
+        genBtcBlocksThenWait(1, 2_500);
+
+        mySwapOffer = aliceClient.getOffer(newOfferId);
+        log.debug("My fetched BsqSwap Buy BSQ (Sell BTC) OFFER:\n{}", toOfferTable.apply(mySwapOffer));
+        assertNotEquals(0, mySwapOffer.getMakerFee());
+
+        runCliGetOffer(newOfferId);
+    }
+
+    @Test
+    @Order(3)
+    public void testBobTakesBsqSwapOffer() {
+        var availableSwapOffer = getAvailableBsqSwapOffer(bobClient, SELL, true);
+
+        // Before sending a TakeOfferRequest, the CLI needs to know what kind of Offer
+        // it is taking (v1 or BsqSwap).  Only BSQ swap offers can be taken with a
+        // single offerId parameter.  Taking v1 offers requires an additional
+        // paymentAccountId param.  The test case knows what kind of offer is being taken,
+        // but we test the gRPC GetOfferCategory service here.
+        var availableOfferCategory = bobClient.getAvailableOfferCategory(availableSwapOffer.getId());
+        assertTrue(availableOfferCategory.equals(BSQ_SWAP));
+
+        sleep(10_000);
+
+        var swapTrade = bobClient.takeBsqSwapOffer(availableSwapOffer.getId());
+        tradeId = swapTrade.getTradeId(); // Cache the tradeId for following test case(s).
+        log.debug("BsqSwap Trade at PREPARATION:\n{}", toTradeDetailTable.apply(swapTrade));
+        assertEquals(PREPARATION.name(), swapTrade.getState());
+        genBtcBlocksThenWait(1, 3_000);
+
+        swapTrade = getBsqSwapTrade(bobClient, tradeId);
+        log.debug("BsqSwap Trade at COMPLETION:\n{}", toTradeDetailTable.apply(swapTrade));
+        assertEquals(COMPLETED.name(), swapTrade.getState());
+
+        runCliGetClosedTrades();
+    }
+
+    @Test
+    @Order(4)
+    public void testCompletedSwapTxConfirmations() {
+        sleep(2_000); // Wait for TX confirmation to happen on node.
+
+        var alicesTrade = getBsqSwapTrade(aliceClient, tradeId);
+        log.debug("Alice's BsqSwap Trade at COMPLETION:\n{}", toTradeDetailTable.apply(alicesTrade));
+        assertEquals(1, alicesTrade.getBsqSwapTradeInfo().getNumConfirmations());
+
+        var bobsTrade = getBsqSwapTrade(bobClient, tradeId);
+        log.debug("Bob's BsqSwap Trade at COMPLETION:\n{}", toTradeDetailTable.apply(bobsTrade));
+        assertEquals(1, bobsTrade.getBsqSwapTradeInfo().getNumConfirmations());
+
+        genBtcBlocksThenWait(1, 2_000);
+
+        bobsTrade = getBsqSwapTrade(bobClient, tradeId);
+        log.debug("Bob's BsqSwap Trade at COMPLETION:\n{}", toTradeDetailTable.apply(bobsTrade));
+        assertEquals(2, bobsTrade.getBsqSwapTradeInfo().getNumConfirmations());
+
+        runCliGetClosedTrades();
+    }
+
+    @Test
+    @Order(5)
+    public void testGetBalancesAfterTrade() {
+        var alicesBalances = aliceClient.getBalances();
+        log.debug("Alice's After Trade Balance:\n{}", formatBalancesTbls(alicesBalances));
+        var bobsBalances = bobClient.getBalances();
+        log.debug("Bob's After Trade Balance:\n{}", formatBalancesTbls(bobsBalances));
+    }
+
+    private TradeInfo getBsqSwapTrade(GrpcClient client, String tradeId) {
+        int numFetchAttempts = 0;
+        while (true) {
+            try {
+                numFetchAttempts++;
+                return client.getTrade(tradeId);
+            } catch (Exception ex) {
+                log.warn(ex.getMessage());
+                if (numFetchAttempts > 9) {
+                    if (checkForLoggedExceptions) {
+                        printNodeExceptionMessages(log);
+                    }
+                    fail(format("Could not find new bsq swap trade after %d attempts.", numFetchAttempts));
+                } else {
+                    sleep(1_000);
+                }
+            }
+        }
+    }
+}