-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API daemon 'getoffer' & 'gettrade' support for BSQ swaps #1 #5827
Merged
sqrrm
merged 14 commits into
bisq-network:master
from
ghubstan:1-basic-api-bsqswap-support
Dec 14, 2021
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
5924312
Adjust bsq-swap-offer related gRPC services & msgs
ghubstan c6aceb0
Adjust bsq-swap-offer related gRPC daemon services
ghubstan 5d63fd7
Partially adjust api proto wrappers for bsq-swap support
ghubstan 713b309
Add String getRole(BsqSwapTrade trade) method
ghubstan 521495c
Add conveniences isFiatOffer(offer), isAltcoinOffer(offer)
ghubstan 3dfbf3f
Partially adjust core api for bsq-swap support
ghubstan 16be357
Paritally adjust bsq-swap-offer related gRPC CLI side classes
ghubstan c5f50b5
Paritally adjust bsq-swap-offer related apitest cases
ghubstan 564303a
Normalize API gRPC bsq-swap related protos & wrappers
ghubstan 9f01279
Merge branch 'master' into 1-basic-api-bsqswap-support
ghubstan fc53ca4
Add CLI output IntegerColumn
ghubstan 4ca878a
Adjust API 'gettrade' for Bsq swaps
ghubstan d8f1e44
Try to hide from pesky codacy
ghubstan b65cc9c
Merge branch 'master' into 1-basic-api-bsqswap-support
ghubstan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is swapOffer not considered an altcoin trade? I guess it makes some sense but also somewhat odd.