Fix API startup's wallet.init failure when wallet is encrypted #5337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the UI's walletPasswordHandler during wallet initialization will fail and block wallet initialization. This change ensures an encrypted wallet does not trigger a walletPasswordHandler.run() if isApiUser=true during startup.
This change sets the WalletsManager key the first time `unlockwallet` is called. This is necessary because the key cannot be set during api daemon startup, as it normally is at UI startup. See commit eb15fda.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug fix makes sure encrypted wallet initialization happens during startup, without prompting the user for a wallet password.
Block UI popups in api startup's encrypted wallet init.
Running the UI's
walletPasswordHandlerduring wallet initialization will block the API's wallet initialization. This change ensures an encrypted wallet does not triggerwalletPasswordHandler.run()ifisApiUser=trueduring startup.Set
WalletsManagerkey in firstCoreWalletsService#unlockWalletcall.This is necessary because the key cannot be set during api daemon startup, which does happen during the UI's startup. See commit eb15fda.