[1.5.2] Improve logs #4973
Merged
[1.5.2] Improve logs #4973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We request each min. the price feed so that get very verbose
For 1.3.9 filter we expect a error log but dont want to show it as warning
…y banned, but rather deactivated/revoked node
As its generic here we cannot influence log level
… mostly an expected case.
We iterate over all trades and messages, so it is expected that the msg which are not assigned to that trade fails. We need to change the handleDecryptedMessageWithPubKey to check first if the msg and trade matches, but that will be done in a dedicated PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce verbosity of logs.
I think all those commites are very low risk, but up to maintainers of they prefer to postpone it to master instead...