Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LegacyAddress instead of Address for BSQ #4681

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Use LegacyAddress instead of Address for BSQ #4681

merged 1 commit into from
Oct 27, 2020

Conversation

oscarguindzberg
Copy link
Contributor

Use LegacyAddress for BSQ related code to make sure we don't accept a segwit address for BSQ by accident.

chimp1984
chimp1984 previously approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

sqrrm
sqrrm previously approved these changes Oct 27, 2020
View reviewed changes
@sqrrm
Copy link
Member

sqrrm commented Oct 27, 2020

@oscarguindzberg Could you sign the commit? I'm unable to merge otherwise.

@oscarguindzberg oscarguindzberg dismissed stale reviews from sqrrm and chimp1984 via 8370bc9 October 27, 2020 16:56
@oscarguindzberg oscarguindzberg force-pushed the removeAddressClassFromBsqClasses branch from 5a0af94 to 8370bc9 Compare October 27, 2020 16:56
@oscarguindzberg
Copy link
Contributor Author

@oscarguindzberg Could you sign the commit? I'm unable to merge otherwise.

@sqrrm sorry I forgot to sign. I just signed it.

sqrrm
sqrrm approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sqrrm sqrrm merged commit 9a87137 into bisq-network:master Oct 27, 2020
@ripcurlx ripcurlx added this to the v1.5.0 milestone Nov 3, 2020
@oscarguindzberg oscarguindzberg mentioned this pull request Nov 10, 2020
Closed
@sqrrm sqrrm mentioned this pull request Nov 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sqrrm sqrrm sqrrm approved these changes

@chimp1984 chimp1984 chimp1984 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@oscarguindzberg @sqrrm @chimp1984 @ripcurlx