Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make price providers cmdline param more readable #4014

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Make price providers cmdline param more readable #4014

merged 2 commits into from
Mar 5, 2020

Conversation

freimair
Copy link
Contributor

We have a line in bisq-desktop --help saying:

  --providers=<host:port[,...]>
        List custom providers

Like so, it is not clear what providers you can set using that config option.

This PR only adds "price" to List custom /price/ providers.

Stumbled upon this during network size metric testing.

cbeams
cbeams suggested changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@cbeams cbeams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: "price provider" is old terminology, we're using pricenode pretty consistently everywhere now.

@freimair freimair requested a review from cbeams February 27, 2020 16:42
@sqrrm sqrrm merged commit bf558c5 into bisq-network:master Mar 5, 2020
@freimair freimair mentioned this pull request Mar 11, 2020
Closed
@freimair freimair deleted the usability branch April 2, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbeams cbeams cbeams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@freimair @cbeams @sqrrm