Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional tweaks to seednode installation script for new use cases #3942

Closed

Conversation

wiz
Copy link
Contributor

@wiz wiz commented Feb 6, 2020

I'm making new one-command installers for other Bisq infrastructure which requires new configuration variables. This PR adds:

  • Allows setting an external Bitcoin node not running on localhost
  • Allows running a non-fullnode (for use cases such as Markets API)
  • Allows enabling dump of Bisq Markets data to JSON files
  • Renames the bisq-seednode service to bisq service

ripcurlx
ripcurlx previously approved these changes Feb 6, 2020
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@wiz wiz force-pushed the seednode-installer-additional-tweaks branch from dd2e8a6 to 3dd6019 Compare February 6, 2020 09:52
@wiz wiz marked this pull request as ready for review February 6, 2020 09:52
@wiz wiz force-pushed the seednode-installer-additional-tweaks branch 2 times, most recently from 8b7a6d5 to a8c4fd7 Compare February 6, 2020 10:04
@wiz wiz force-pushed the seednode-installer-additional-tweaks branch from a8c4fd7 to 345abda Compare February 6, 2020 10:11
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants