Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional information for a local Bitcoin Core v0.19+ #3939

Merged
merged 2 commits into from
Feb 5, 2020
Merged

Add additional information for a local Bitcoin Core v0.19+ #3939

merged 2 commits into from
Feb 5, 2020

Conversation

ripcurlx
Copy link
Contributor

@ripcurlx ripcurlx commented Feb 5, 2020 •
edited
Loading

Bildschirmfoto 2020-02-05 um 11 32 24

@ripcurlx @wiz
Improve wording
040b8d5 
Co-Authored-By: wiz <[email protected]>
wiz
wiz approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx added the is:priority PR or issue marked with this label is up for compensation label Feb 5, 2020
sqrrm
sqrrm approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

core/src/main/resources/i18n/displayStrings.properties
@@ -2661,6 +2661,7 @@ popup.securityRecommendation.msg=We would like to remind you to consider using p

popup.bitcoinLocalhostNode.msg=Bisq detected a locally running Bitcoin Core node (at localhost).\n\
Please make sure that this node is fully synced before you start Bisq and that it is not running in pruned mode.
popup.bitcoinLocalhostNode.additionalRequirements=\n\nStarting with Bitcoin Core v0.19 you have to manually enable bloom filters by setting peerbloomfilters=1 in your bitcoin.conf configuration file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it easier to read when the long lines are broken with a \

@sqrrm sqrrm merged commit d88a8ac into bisq-network:master Feb 5, 2020
@ripcurlx ripcurlx mentioned this pull request Feb 6, 2020
Closed
@huey735
Copy link
Contributor

huey735 commented Feb 9, 2020 •
edited
Loading

@HiFi24Seven over at reddit said this:

[email protected]/32 is a better way to do this, as it only enables bloomfilters on connections from your local machine. The reason this is a better approach is because bloomfilters have been found to be a security vulnerability and create an attack vector when enabled for all incoming connections, which is the reason they are now disabled by default.

I'm not sure of the merits but I thought it'd be worth mentioning it.

@sqrrm sqrrm mentioned this pull request Feb 10, 2020
Closed
@ripcurlx ripcurlx mentioned this pull request Feb 14, 2020
Closed
@dmp1ce
Copy link

dmp1ce commented May 23, 2020

I connected to my node using the .onion address and didn't get this message. I didn't realize I needed to set peerbloomfilters=1 and I was further confused in that I thought peerbloomfilters=1 was the default for version 0.19.1.

@ripcurlx ripcurlx deleted the improve-local-node-info branch July 16, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiz wiz wiz approved these changes

@sqrrm sqrrm sqrrm approved these changes

Assignees
No one assigned
Labels
is:priority PR or issue marked with this label is up for compensation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ripcurlx @huey735 @dmp1ce @wiz @sqrrm