Fix dark mode slider switch not disabling dark mode on first try

[wiz]

Apparently the preferences property listener I was using doesn't call
the event handler on the first change for some reason. This is a
workaround to change the CSS theme directly from the slider switch.

Needs review and testing! Fixes #3447

[ripcurlx]

I'll have a look at this behavior today and if it caused issues in other parts of the code as well.

[ripcurlx]

@wiz The problem is that private final IntegerProperty cssThemeProperty = new SimpleIntegerProperty(prefPayload.getCssTheme()); gets initialized before the stored payload is initialized which causes the value of the cssThemeProperty always to set to 0. That is also the reason why the listener is not triggered the first time when changing back to light mode after a restart.

[ripcurlx]

You missed to update the value in readPersisted in the Preferences class (L:271+). But I also saw during investigation that we are still having properties there we don't use anymore so I'll create another PR cleaning up the unused properties and fixing this issue as well.

[ripcurlx]

Closing as superseded by #3771 .

[wiz]

The problem is that private final IntegerProperty cssThemeProperty = new SimpleIntegerProperty(prefPayload.getCssTheme()); gets initialized before the stored payload is initialized which causes the value of the cssThemeProperty always to set to 0

Ah that's why - good thing it was my bug and not something weird elsewhere :)
Thanks for fixing