Add missing check if capability is not empty before checking mandatory capabilities #3162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y capabilities We do not get the capabilities with all network messages so we have to skip the test if the mandatory capability is included if capabilities is empty.
chimp1984
changed the title
- Move check for empty capability to connection class. - Add MANDATORY_CAPABILITIES_NOT_SUPPORTED - Add comment that capabilities can be empty
|
Fixes #3161 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not get the capabilities with all network messages so we have to
skip the test if the mandatory capability is included if capabilities
is empty.
fixes #3161 thus, deprecates and therefore closes #3163