Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split the pb.java file into multiple files #3005

Merged
merged 4 commits into from
Jul 26, 2019

Conversation

christophsturm
Copy link
Contributor

the pb.java file was making idea crazy.

since we have many protobuf classes that have the same name as our own classes I changed the protobuf package to "protobuf" to have a short way to reference it via its whole package in case of a naming collision.

@christophsturm christophsturm requested a review from ripcurlx as a code owner July 25, 2019 12:12
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@sqrrm sqrrm merged commit 70b7660 into bisq-network:master Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants