[WIP] Increase tolerated trade limit from 0.01 BTC to 0.02 BTC #2904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripcurlx
changed the title
|
What is the effect on compatibility of old and new clients when we hard code a change like this? Will old clients just see new offers that they consider risky and not be able to trade with them? Will new clients try to take offers of > 0.01 from old clients and get rejected? Should we try to handle at least future cases with some kind of versioning so that it doesn't cause too much extra support and arbitration work? |
ripcurlx
changed the title
|
Closing branch for now because of the backwards compatibility risk and the upcoming account signing feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bisq-network/proposals#95.