Show BSQ trading fee more explicitly when funding your offer #2379
Conversation
ripcurlx
commented
Feb 6, 2019
•
ripcurlx
commented
- Fixes DAO: Point out BSQ separately in "Fund your offer" popup #2075.
- Fixes wrong total funds value in info popup and funds tooltip
- Fixes missing info icon in Funds needed field
- Fixes positioning of info icons
ripcurlx
force-pushed
the
improve-fund-your-offer-popup
branch
from
700a854 to
f43032d
Compare
| @@ -373,6 +373,7 @@ createOffer.fundsBox.networkFee=Mining fee | |||
| createOffer.fundsBox.placeOfferSpinnerInfo=Offer publishing is in progress ... | |||
| createOffer.fundsBox.paymentLabel=Bisq trade with ID {0} | |||
| createOffer.fundsBox.fundsStructure=({0} security deposit, {1} trade fee, {2} mining fee) | |||
| createOffer.fundsBox.fundsStructure.BSQ=({0} security deposit, {1} mining fee) + {2} trade fee | |||
There was a problem hiding this comment.
Maybe this should keep the same order (deposit, trade fee, mining fee) as createOffer.fundsBox.fundsStructure for less confusion?
There was a problem hiding this comment.
The reason why I did it like that is, that it would otherwise look like as if it is part of the total btc funds needed.
So I implemented it as follows:
There was a problem hiding this comment.
Ah, perhaps the ordering should be deposit, mining, trade fee for both?
There was a problem hiding this comment.
On first sight yes, but we have this order on a couple of places and it makes sense from my point of view to have it as it is right now:
The only problem is to mix it in the total funds field with the BSQ value.
I personally would go with this little inconsistency and have the order in this field different between BSQ and BTC trading fees.
There was a problem hiding this comment.
Yeah, that's a lot to change, then just go with your original suggestion unless we have an obviously better way to do it.
