List LitecoinZ (LTZ) #2221
List LitecoinZ (LTZ) #2221
Conversation
| @@ -147,6 +147,11 @@ private void onSaveNewAccount(PaymentAccount paymentAccount) { | |||
| .useIUnderstandButton() | |||
| .show(); | |||
| break; | |||
| case "LTZ": | |||
| new Popup<>().information(Res.get("account.altcoin.popup.LTZ.msg", "LTZ")) | |||
There was a problem hiding this comment.
Does this message bring any added value at this point?
It duplicates validation error.
There was a problem hiding this comment.
If you see messages are quite similar to ZEC but customized for LTZ:
account.altcoin.popup.LTZ.msg=When using {0} you can only use the transparent addresses (starting with L) not the z-addresses (private), because the arbitrator would not be able to verify the transaction with z-addresses.
account.altcoin.popup.ZEC.msg=When using {0} you can only use the transparent addresses (starting with t) not the z-addresses (private), because the arbitrator would not be able to verify the transaction with z-addresses.
There was a problem hiding this comment.
I know, but still it doesn't add any value to repeat validation message.
I value your effort with all those translations.
Team will have to discuss if post save popups with this type of messages have any sense.
There was a problem hiding this comment.
Well the sense is to advice customers to use only transparent address and not z-address because they are not supported. Now, because LTZ use address starting with 'L' and not with 't' like ZEC does
|
Just a general comment on changing/adding translations. This only should be done in the English source file (displayStrings.properties) as all other translations are translated within Transifex and will be overwritten/updated before every release. |
|
@ripcurlx thanks for the info |
|
Please rebase on top of master and resolve the conflicts. |
|
Ready in a couple of hours. Hold on |
|
@blabno done. Please review my changes and merge this PR. |
|
Also it needs conflict resolution now, because of other merged assets. |
|
rebase and squash into a single commit |
|
@blabno squashed |
|
Thank you. Ready for merge. |
The aim of this PR is to list LitecoinZ (LTZ) on bisq.
This PR replace the previous #1910 closed by @ManfredKarrer
Regards,
Mark